Last modified: 2014-09-27 01:59:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T69216, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 67216 - Have unit tests of all wmf deployed extensions pass when installed together, in both PHP-Zend and HHVM (tracking)
Have unit tests of all wmf deployed extensions pass when installed together, ...
Status: NEW
Product: Wikimedia
Classification: Unclassified
Continuous integration (Other open bugs)
wmf-deployment
All All
: High normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: tracking
Depends on: 65895 67148 67295 67302 67608 67615 68231 68629 68636 68644 68648 68651 68652 68654 68655 68672 68700 68955 68956 68957 55886 65875 65876 65877 65896 66937 66942 66943 67036 67043 67060 67138 67139 67142 67296 67297 67300 67353 67366 67598 68634 68646 68649 68697 68699 68958
Blocks: tracking 58772
  Show dependency treegraph
 
Reported: 2014-06-27 21:35 UTC by Antoine "hashar" Musso (WMF)
Modified: 2014-09-27 01:59 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
php5 phpunit.php (314.82 KB, text/plain)
2014-07-26 23:20 UTC, Nemo
Details

Description Antoine "hashar" Musso (WMF) 2014-06-27 21:35:17 UTC
When installing all the MediaWiki extensions currently deployed on the Wikimedia cluster with a dummy LocalSettings.php, we end up with a lot of failures, bad interactions between extensions or core tests broken via hooks.  Some extensions even end up throwing fatal errors.

To help migrate to HHVM, we would need to be able to run the unit tests of core and of all the extensions and have them pass.

Ori has worked on this a bit for HHVM and already reported a fair amount of bugs.

Antoine has been working on an experimental Jenkins Job that run all wmf extensions tests.


Lets join the effort, fill bug and track them there. Then reach out to the other developers and get everything fixed.
Comment 1 Antoine "hashar" Musso (WMF) 2014-06-27 21:41:36 UTC
Add bugs Ori and I filled.
Comment 2 James Forrester 2014-06-27 21:48:46 UTC
Relabel per discussion.
Comment 3 Antoine "hashar" Musso (WMF) 2014-06-30 14:12:54 UTC
A few more extension that can pass the installer / fail tests.
Comment 4 Nemo 2014-06-30 21:56:17 UTC
Thanks a bunch for working on this. Those who shouted for help on wikitech-l and have been unable for years to run tests on their own environment / with their own configuration will be enthusiastic.
Comment 5 Antoine "hashar" Musso (WMF) 2014-06-30 22:30:42 UTC
I am merely feeling bugs and we will attempt to fix as many possible. But we could use some help :-) Please spread the word to wikitech-l!   New bugs would be specially appreciated.

The aim is to have core + all wmf extensions to pass the PHPUnit test suite.
Comment 6 Ori Livneh 2014-07-03 06:59:08 UTC
This is awesome :) Thanks for pushing this, Antoine.
Comment 7 Antoine "hashar" Musso (WMF) 2014-07-07 20:57:25 UTC
Status as of today.

I have commented out the following extensions for various reasons mentioned in the commit message https://git.wikimedia.org/commit/integration%2Fjenkins-job-builder-config/50d2cda7ffca7655889a48b25fccd3ce15977ff6

#mediawiki/extensions/CentralAuth
#mediawiki/extensions/Math
#mediawiki/extensions/OAI
#mediawiki/extensions/Oversight
#mediawiki/extensions/RandomRootPage
#mediawiki/extensions/SemanticForms
#mediawiki/extensions/SemanticMediaWiki
#mediawiki/extensions/SemanticResultFormats
#mediawiki/extensions/Translate
#mediawiki/extensions/Validator
#mediawiki/extensions/ZeroRatedMobileAccess
#mediawiki/extensions/timeline

There are bug filled for most of them.

The complete list from the Jenkins configuration:

https://git.wikimedia.org/blob/integration%2Fjenkins-job-builder-config/50d2cda7ffca7655889a48b25fccd3ce15977ff6/mediawiki-extensions.yaml#L147


A test report can be find at: https://integration.wikimedia.org/ci/job/mediawiki-core-extensions-integration/68/testReport/

Almost all of the failures are parser tests which hardcode expected HTML output. But since some extensions register hooks that further adjust the HTML output, that does not play well. Bug 67302 - ""MultimediaViewer breaks Cite extension parser tests"" has some more details.
Comment 8 Nemo 2014-07-26 23:20:14 UTC
Created attachment 16044 [details]
php5 phpunit.php

I run php5 phpunit.php after enabling all gerrit extension having unit tests and almost all MediaWiki-Vagrant roles (http://paste.debian.net/111811/ minus roles globalcssjs math mathsearch cirrussearch) and there's quite some output to process...
Comment 9 Antoine "hashar" Musso (WMF) 2014-07-28 09:27:39 UTC
(In reply to Nemo from comment #8)
> Created attachment 16044 [details]
> php5 phpunit.php
> 
> I run php5 phpunit.php after enabling all gerrit extension having unit tests
> and almost all MediaWiki-Vagrant roles (http://paste.debian.net/111811/
> minus roles globalcssjs math mathsearch cirrussearch) and there's quite some
> output to process...

I am going to have a Jenkins job triggered for all extensions.  Gotta polish up some details but I have a working base to make it happen soon ™

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links