Last modified: 2014-07-31 22:50:59 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T70646, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 68646 - phpunit failure: LuaStandalone: TitleLibraryTests: Failed asserting that two strings are identical
phpunit failure: LuaStandalone: TitleLibraryTests: Failed asserting that two ...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Echo (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 67216
  Show dependency tree / graph
 
Reported: 2014-07-27 00:11 UTC by Nemo
Modified: 2014-07-31 22:50 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Nemo 2014-07-27 00:11:06 UTC 
When runnning with a bunch other extensions (under php5), http://paste.debian.net/111811/

126) LuaSandbox: TitleLibraryTests[46]: .fullUrl()
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
 {
-  "//wiki.local/wiki/Main_Page",
+  "//wiki.local/wiki/Main_Page#Section_8",
   "//wiki.local/wiki/Module:TestFramework",
   "//test.wikipedia.org/wiki/Module:TestFramework",
   "//wiki.local/wiki/Talk:Has/A/Subpage#frag",
   "//wiki.local/wiki/Not/A/Subpage",
   "//wiki.local/wiki/Module_talk:Test_Framework#_frag_frag",
   "//wiki.local/wiki/Module_talk:Test_Framework#_frag_frag",
 }

/srv/vagrant/mediawiki/extensions/Scribunto/tests/engines/LuaCommon/LuaEngineTestBase.php:252
/srv/vagrant/mediawiki/tests/phpunit/MediaWikiTestCase.php:133
/srv/vagrant/mediawiki/tests/phpunit/MediaWikiPHPUnitCommand.php:42
/srv/vagrant/mediawiki/tests/phpunit/phpunit.php:160

127) LuaSandbox: TitleLibraryTests[47]: .fullUrl() 2
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
 {
-  "//wiki.local/w/index.php?title=Main_Page&action=test",
+  "//wiki.local/w/index.php?title=Main_Page&action=test#Section_8",
   "//wiki.local/w/index.php?title=Module:TestFramework&action=test",
   "//test.wikipedia.org/wiki/Module:TestFramework?action=test",
   "//wiki.local/w/index.php?title=Talk:Has/A/Subpage&action=test#frag",
   "//wiki.local/w/index.php?title=Not/A/Subpage&action=test",
   "//wiki.local/w/index.php?title=Module_talk:Test_Framework&action=test#_frag_frag",
   "//wiki.local/w/index.php?title=Module_talk:Test_Framework&action=test#_frag_frag",
 }

/srv/vagrant/mediawiki/extensions/Scribunto/tests/engines/LuaCommon/LuaEngineTestBase.php:252
/srv/vagrant/mediawiki/tests/phpunit/MediaWikiTestCase.php:133
/srv/vagrant/mediawiki/tests/phpunit/MediaWikiPHPUnitCommand.php:42
/srv/vagrant/mediawiki/tests/phpunit/phpunit.php:160

128) LuaSandbox: TitleLibraryTests[48]: .fullUrl() 3
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
 {
-  "http://wiki.local/wiki/Main_Page",
+  "http://wiki.local/wiki/Main_Page#Section_8",
   "http://wiki.local/wiki/Module:TestFramework",
   "http://test.wikipedia.org/wiki/Module:TestFramework",
   "http://wiki.local/wiki/Talk:Has/A/Subpage#frag",
   "http://wiki.local/wiki/Not/A/Subpage",
   "http://wiki.local/wiki/Module_talk:Test_Framework#_frag_frag",
   "http://wiki.local/wiki/Module_talk:Test_Framework#_frag_frag",
 }

/srv/vagrant/mediawiki/extensions/Scribunto/tests/engines/LuaCommon/LuaEngineTestBase.php:252
/srv/vagrant/mediawiki/tests/phpunit/MediaWikiTestCase.php:133
/srv/vagrant/mediawiki/tests/phpunit/MediaWikiPHPUnitCommand.php:42
/srv/vagrant/mediawiki/tests/phpunit/phpunit.php:160

129) LuaSandbox: TitleLibraryTests[50]: .canonicalUrl()
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
 {
-  "http://wiki.local/wiki/Main_Page",
+  "http://wiki.local/wiki/Main_Page#Section_8",
   "http://wiki.local/wiki/Module:TestFramework",
   "http://test.wikipedia.org/wiki/Module:TestFramework",
   "http://wiki.local/wiki/Talk:Has/A/Subpage#frag",
   "http://wiki.local/wiki/Not/A/Subpage",
   "http://wiki.local/wiki/Module_talk:Test_Framework#_frag_frag",
   "http://wiki.local/wiki/Module_talk:Test_Framework#_frag_frag",
 }

/srv/vagrant/mediawiki/extensions/Scribunto/tests/engines/LuaCommon/LuaEngineTestBase.php:252
/srv/vagrant/mediawiki/tests/phpunit/MediaWikiTestCase.php:133
/srv/vagrant/mediawiki/tests/phpunit/MediaWikiPHPUnitCommand.php:42
/srv/vagrant/mediawiki/tests/phpunit/phpunit.php:160

130) LuaStandalone: TitleLibraryTests[46]: .fullUrl()
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
 {
-  "//wiki.local/wiki/Main_Page",
+  "//wiki.local/wiki/Main_Page#Section_8",
   "//wiki.local/wiki/Module:TestFramework",
   "//test.wikipedia.org/wiki/Module:TestFramework",
   "//wiki.local/wiki/Talk:Has/A/Subpage#frag",
   "//wiki.local/wiki/Not/A/Subpage",
   "//wiki.local/wiki/Module_talk:Test_Framework#_frag_frag",
   "//wiki.local/wiki/Module_talk:Test_Framework#_frag_frag",
 }

/srv/vagrant/mediawiki/extensions/Scribunto/tests/engines/LuaCommon/LuaEngineTestBase.php:252
/srv/vagrant/mediawiki/tests/phpunit/MediaWikiTestCase.php:133
/srv/vagrant/mediawiki/tests/phpunit/MediaWikiPHPUnitCommand.php:42
/srv/vagrant/mediawiki/tests/phpunit/phpunit.php:160

131) LuaStandalone: TitleLibraryTests[47]: .fullUrl() 2
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
 {
-  "//wiki.local/w/index.php?title=Main_Page&action=test",
+  "//wiki.local/w/index.php?title=Main_Page&action=test#Section_8",
   "//wiki.local/w/index.php?title=Module:TestFramework&action=test",
   "//test.wikipedia.org/wiki/Module:TestFramework?action=test",
   "//wiki.local/w/index.php?title=Talk:Has/A/Subpage&action=test#frag",
   "//wiki.local/w/index.php?title=Not/A/Subpage&action=test",
   "//wiki.local/w/index.php?title=Module_talk:Test_Framework&action=test#_frag_frag",
   "//wiki.local/w/index.php?title=Module_talk:Test_Framework&action=test#_frag_frag",
 }

/srv/vagrant/mediawiki/extensions/Scribunto/tests/engines/LuaCommon/LuaEngineTestBase.php:252
/srv/vagrant/mediawiki/tests/phpunit/MediaWikiTestCase.php:133
/srv/vagrant/mediawiki/tests/phpunit/MediaWikiPHPUnitCommand.php:42
/srv/vagrant/mediawiki/tests/phpunit/phpunit.php:160

132) LuaStandalone: TitleLibraryTests[48]: .fullUrl() 3
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
 {
-  "http://wiki.local/wiki/Main_Page",
+  "http://wiki.local/wiki/Main_Page#Section_8",
   "http://wiki.local/wiki/Module:TestFramework",
   "http://test.wikipedia.org/wiki/Module:TestFramework",
   "http://wiki.local/wiki/Talk:Has/A/Subpage#frag",
   "http://wiki.local/wiki/Not/A/Subpage",
   "http://wiki.local/wiki/Module_talk:Test_Framework#_frag_frag",
   "http://wiki.local/wiki/Module_talk:Test_Framework#_frag_frag",
 }

/srv/vagrant/mediawiki/extensions/Scribunto/tests/engines/LuaCommon/LuaEngineTestBase.php:252
/srv/vagrant/mediawiki/tests/phpunit/MediaWikiTestCase.php:133
/srv/vagrant/mediawiki/tests/phpunit/MediaWikiPHPUnitCommand.php:42
/srv/vagrant/mediawiki/tests/phpunit/phpunit.php:160

133) LuaStandalone: TitleLibraryTests[50]: .canonicalUrl()
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
 {
-  "http://wiki.local/wiki/Main_Page",
+  "http://wiki.local/wiki/Main_Page#Section_8",
   "http://wiki.local/wiki/Module:TestFramework",
   "http://test.wikipedia.org/wiki/Module:TestFramework",
   "http://wiki.local/wiki/Talk:Has/A/Subpage#frag",
   "http://wiki.local/wiki/Not/A/Subpage",
   "http://wiki.local/wiki/Module_talk:Test_Framework#_frag_frag",
   "http://wiki.local/wiki/Module_talk:Test_Framework#_frag_frag",
 }

/srv/vagrant/mediawiki/extensions/Scribunto/tests/engines/LuaCommon/LuaEngineTestBase.php:252
/srv/vagrant/mediawiki/tests/phpunit/MediaWikiTestCase.php:133
/srv/vagrant/mediawiki/tests/phpunit/MediaWikiPHPUnitCommand.php:42
/srv/vagrant/mediawiki/tests/phpunit/phpunit.php:160
Comment 1 Brad Jorsch 2014-07-27 19:55:50 UTC 
I'm inclined to close this as invalid. If some other extension is screwing around with the value of the main page, it's probably going to break a lot of stuff.
Comment 2 Nemo 2014-07-27 20:14:56 UTC 
(In reply to Brad Jorsch from comment #1)
> If some other extension is screwing
> around with the value of the main page, it's probably going to break a lot
> of stuff.

Do those tests assume that the main page is at [[Main Page]]?
Comment 3 Antoine "hashar" Musso (WMF) 2014-07-29 11:56:22 UTC 
I am moving this to the Echo extension.

In Echo tests/NotificationFormatterTest.php there is a test that ends up invoking the Linker to create full URL for Main_page and pass it a fragment.

Title::newMainPage() is really Title::newFromText('Main_Page') which is cached.  Whenever the fragment is set, it stuck in the cache entry and later call to Title::newMainPage() yields a Title object which has the fragment.


The ugly workaround is to have the Echo test to reset the fragment.
Comment 4 Gerrit Notification Bot 2014-07-29 11:58:36 UTC 
Change 150191 had a related patch set uploaded by Hashar:
Clear up cached Main_page title in test

https://gerrit.wikimedia.org/r/150191
Comment 5 Antoine "hashar" Musso (WMF) 2014-07-29 13:48:03 UTC 
The patch seems to fix the interactions between Echo and Scribunto.  The Jenkins test report page shows a lot of entry with 'Fixed' at https://integration.wikimedia.org/ci/job/mediawiki-core-extensions-integration/78/testReport/(root)/Scribunto_LuaTitleLibraryTests__testLua/
Comment 6 Gerrit Notification Bot 2014-07-31 18:52:34 UTC 
Change 150191 merged by jenkins-bot:
Clear up cached Main_page title in test

https://gerrit.wikimedia.org/r/150191
Comment 7 Antoine "hashar" Musso (WMF) 2014-07-31 18:59:10 UTC 
Nemo can you confirm the tests are fixed in Vagrant please?
Comment 8 Nemo 2014-07-31 22:50:59 UTC 
(In reply to Antoine "hashar" Musso from comment #7)
> Nemo can you confirm the tests are fixed in Vagrant please?

Yep, looks fixed. Thanks!
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links