Last modified: 2014-07-28 00:48:24 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T70654, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 68654 - phpunit failure: ApiOptionsTest::testReset User::saveSettings() was not expected to be called more than once
phpunit failure: ApiOptionsTest::testReset User::saveSettings() was not expec...
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
BetaFeatures (Other open bugs)
master
All All
: Lowest normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 67216
  Show dependency tree / graph
 
Reported: 2014-07-27 00:44 UTC by Nemo
Modified: 2014-07-28 00:48 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
nemobis@tools-login:/shared/mediawiki$ ack-grep --php "saveSettings\(" (9.25 KB, text/plain)
2014-07-27 22:29 UTC, Nemo 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Nemo 2014-07-27 00:44:25 UTC 
From where could this come from (see http://paste.debian.net/111811/ for the enabled extensions)?

12) ApiOptionsTest::testReset
User::saveSettings() was not expected to be called more than once.

/srv/vagrant/mediawiki/includes/api/ApiOptions.php:119
/srv/vagrant/mediawiki/tests/phpunit/includes/api/ApiOptionsTest.php:151
/srv/vagrant/mediawiki/tests/phpunit/includes/api/ApiOptionsTest.php:233
/srv/vagrant/mediawiki/tests/phpunit/MediaWikiTestCase.php:133
/srv/vagrant/mediawiki/tests/phpunit/MediaWikiPHPUnitCommand.php:42
/srv/vagrant/mediawiki/tests/phpunit/phpunit.php:160
Comment 1 Brad Jorsch 2014-07-27 20:00:10 UTC 
Presumably some extension hooking 'UserResetAllOptions' and calling saveSettings.
Comment 2 Nemo 2014-07-27 22:27:07 UTC 
(In reply to Brad Jorsch from comment #1)
> Presumably some extension hooking 'UserResetAllOptions' and calling
> saveSettings.

nemobis@tools-login:/shared/mediawiki$ ack-grep UserResetAllOptions extensions/ 

No results. Many for:

nemobis@tools-login:/shared/mediawiki$ ack-grep --php "saveSettings\("
Comment 3 Nemo 2014-07-27 22:29:08 UTC 
Created attachment 16050 [details]
nemobis@tools-login:/shared/mediawiki$ ack-grep --php "saveSettings\("
Comment 4 Nemo 2014-07-28 00:07:50 UTC 
Maybe BetaFeatures? Doing what in attachment 16052 [details] minus Wikibase:

vagrant@nemobis:/vagrant/mediawiki/tests/phpunit$ php5 phpunit.php includes
PHPUnit 3.7.37 by Sebastian Bergmann.

[...]

14) ApiOptionsTest::testSpecialOption
User::saveSettings() was not expected to be called.

/srv/vagrant/mediawiki/extensions/BetaFeatures/BetaFeaturesHooks.php:308
/srv/vagrant/mediawiki/includes/Hooks.php:206
/srv/vagrant/mediawiki/includes/GlobalFunctions.php:4031
/srv/vagrant/mediawiki/includes/Preferences.php:99
/srv/vagrant/mediawiki/includes/api/ApiOptions.php:75
/srv/vagrant/mediawiki/tests/phpunit/includes/api/ApiOptionsTest.php:151
/srv/vagrant/mediawiki/tests/phpunit/includes/api/ApiOptionsTest.php:405
/srv/vagrant/mediawiki/tests/phpunit/MediaWikiTestCase.php:133
/srv/vagrant/mediawiki/tests/phpunit/MediaWikiPHPUnitCommand.php:42

15) ApiOptionsTest::testUnknownOption
User::saveSettings() was not expected to be called.

/srv/vagrant/mediawiki/extensions/BetaFeatures/BetaFeaturesHooks.php:308
/srv/vagrant/mediawiki/includes/Hooks.php:206
/srv/vagrant/mediawiki/includes/GlobalFunctions.php:4031
/srv/vagrant/mediawiki/includes/Preferences.php:99
/srv/vagrant/mediawiki/includes/api/ApiOptions.php:75
/srv/vagrant/mediawiki/tests/phpunit/includes/api/ApiOptionsTest.php:151
/srv/vagrant/mediawiki/tests/phpunit/includes/api/ApiOptionsTest.php:428
/srv/vagrant/mediawiki/tests/phpunit/MediaWikiTestCase.php:133
/srv/vagrant/mediawiki/tests/phpunit/MediaWikiPHPUnitCommand.php:42
Comment 5 Brad Jorsch 2014-07-28 00:38:27 UTC 
That'd probably do it: that's hooking GetPreferences and triggering an extra pref save.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links