Last modified: 2014-07-02 16:50:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67896, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 65896 - TitleKey does not pass Jenkins unit tests (sqlite compatibility)


Summary:	TitleKey does not pass Jenkins unit tests (sqlite compatibility)

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	TitleKey (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	High normal (vote)
Target Milestone:	MW 1.23 version
Assigned To:	Antoine "hashar" Musso (WMF)

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	sqlite 65874 67216
	Show dependency tree / graph

Reported:	2014-05-29 15:57 UTC by Antoine "hashar" Musso (WMF)
Modified:	2014-07-02 16:50 UTC (History)
CC List:	1 user (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Flags:	aklapper: Backport_to_Stable+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Antoine "hashar" Musso (WMF) 2014-05-29 15:57:12 UTC

The TitleKey extension is not compatible with sqlite. The installer ends up with a database error:

00:00:02.815 A database query error has occurred.
00:00:02.816 Query: CREATE TABLE titlekey (
00:00:02.817  tk_page INTEGER  NOT NULL,
00:00:02.818  tk_namespace INTEGER NOT NULL,
00:00:02.819  tk_key TEXT  NOT NULL,
00:00:02.819  PRIMARY KEY tk_page (tk_page),
00:00:02.820  INDEX name_key (tk_namespace, tk_key)
00:00:02.821  )
00:00:02.822 Function: DatabaseBase::sourceFile( /srv/ssd/jenkins-slave/workspace/mwext-TitleKey-testextensions-master/extensions/TitleKey/titlekey.sql )
00:00:02.823 Error: 1 near "tk_page": syntax error

Comment 1 Gerrit Notification Bot 2014-05-29 15:58:47 UTC

Change 136110 had a related patch set uploaded by Hashar:
Ignore TitleKey unit tests

https://gerrit.wikimedia.org/r/136110

Comment 2 Gerrit Notification Bot 2014-05-29 15:59:42 UTC

Change 136110 merged by jenkins-bot:
Ignore TitleKey unit tests

https://gerrit.wikimedia.org/r/136110

Comment 3 Antoine "hashar" Musso (WMF) 2014-06-30 14:14:02 UTC

We really need tests to pass when all wmf extensions are installed together. That is preventing us from progression toward the HHVM migrating. Raising priority to High.

Comment 4 Gerrit Notification Bot 2014-07-01 13:20:08 UTC

Change 143294 had a related patch set uploaded by Hashar:
Sqlite compatibility

https://gerrit.wikimedia.org/r/143294

Comment 5 Gerrit Notification Bot 2014-07-01 13:30:22 UTC

Change 143298 had a related patch set uploaded by Hashar:
Make some extensions voting

https://gerrit.wikimedia.org/r/143298

Comment 6 Gerrit Notification Bot 2014-07-01 13:31:42 UTC

Change 143298 merged by jenkins-bot:
Make some extensions voting

https://gerrit.wikimedia.org/r/143298

Comment 7 Gerrit Notification Bot 2014-07-01 13:45:57 UTC

Change 143294 merged by jenkins-bot:
Sqlite compatibility

https://gerrit.wikimedia.org/r/143294

Comment 8 Gerrit Notification Bot 2014-07-02 10:47:47 UTC

Change 143592 had a related patch set uploaded by Hashar:
Sqlite compatibility

https://gerrit.wikimedia.org/r/143592

Comment 9 Gerrit Notification Bot 2014-07-02 11:04:27 UTC

Change 143592 merged by jenkins-bot:
Sqlite compatibility

https://gerrit.wikimedia.org/r/143592

Comment 10 Antoine "hashar" Musso (WMF) 2014-07-02 12:40:29 UTC

Backported to REL1_23.

Note You need to log in before you can comment on or make changes to this bug.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links