Last modified: 2014-07-03 06:54:32 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T69060, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 67060 - Gadgets: Fix failing unit test "GadgetsTest::testPreferences: isset( $options['<gadget-section-keep-section2>'] )"
Gadgets: Fix failing unit test "GadgetsTest::testPreferences: isset( $options...
Status: RESOLVED WORKSFORME
Product: MediaWiki extensions
Classification: Unclassified
Gadgets (Other open bugs)
master
All All
: High normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 67216
  Show dependency tree / graph
 
Reported: 2014-06-24 23:47 UTC by Ori Livneh
Modified: 2014-07-03 06:54 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Ori Livneh 2014-06-24 23:47:02 UTC 
29) GadgetsTest::testPreferences
Failed asserting that false is true.

/srv/mediawiki/extensions/Gadgets/tests/GadgetTest.php:75
/srv/mediawiki/tests/phpunit/MediaWikiTestCase.php:133
/srv/mediawiki/tests/phpunit/MediaWikiPHPUnitCommand.php:42
/srv/mediawiki/tests/phpunit/phpunit.php:160

The assert that is failing is:

  $this->assertTrue( isset( $options['<gadget-section-keep-section2>'] ) );
Comment 1 Antoine "hashar" Musso (WMF) 2014-06-30 14:08:45 UTC 
We really need tests to pass when all wmf extensions are installed together. That is preventing us from progression toward the HHVM migrating. Raising priority to High.
Comment 2 Kunal Mehta (Legoktm) 2014-07-02 10:57:56 UTC 
Just ran the tests and they passed for me...
Comment 3 Kunal Mehta (Legoktm) 2014-07-02 11:02:01 UTC 
I checked out the parent of I9b7fb065ea9e235e6c5e7ea5116ccacac91f8846 and they still passed. Is it still failing for you Ori?
Comment 4 Max Semenik 2014-07-03 06:54:32 UTC 
Not reproduceable anymore.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links