Last modified: 2014-07-18 00:38:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68937, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 66937 - HHVM: TemplateDataBlobTest::testGetDataInLanguage fails with "Invalid operand type was used: expecting an array"
HHVM: TemplateDataBlobTest::testGetDataInLanguage fails with "Invalid operand...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
TemplateData (Other open bugs)
master
All All
: High normal (vote)
: ---
Assigned To: Editing team bugs – take if you're interested!
: hhvm
Depends on:
Blocks: 67216
  Show dependency treegraph
 
Reported: 2014-06-22 04:58 UTC by Ori Livneh
Modified: 2014-07-18 00:38 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ori Livneh 2014-06-22 04:58:58 UTC
Test passes in Zend PHP, but fails in HHVM.

PHPUnit 4.1.3 by Sebastian Bergmann.

Configuration read from /srv/mediawiki/tests/phpunit/suite.xml

...............................................................  63 / 193 ( 32%)
............................................................... 126 / 193 ( 65%)
.................................................E

Time: 1.12 seconds, Memory: 21.39Mb

There was 1 error:

1) TemplateDataBlobTest::testGetDataInLanguage with data set #7 (array('{
					"params": {
						"foo": {}
					},
					"sets": [
						{
							"label": {
								"es": "Spanish",
								"de": "German"
							},
							"params": ["foo"]
						}
					]
				}
				', '{
					"description": null,
					"params": {
						"foo": {
							"label": null,
							"required": false,
							"suggested": false,
							"description": null,
							"deprecated": false,
							"aliases": [],
							"default": "",
							"type": "unknown"
						}
					},
					"paramOrder": ["foo"],
					"sets": [
						{
							"label": "Spanish",
							"params": ["foo"]
						}
					]
				}
				', 'fr', 'Set label is not optional, choose first available key as final fallback'))
Invalid operand type was used: expecting an array

/srv/mediawiki/extensions/TemplateData/TemplateDataBlob.php:522
/srv/mediawiki/extensions/TemplateData/tests/TemplateDataBlobTest.php:684
/srv/mediawiki/tests/phpunit/MediaWikiTestCase.php:133
/srv/mediawiki/tests/phpunit/MediaWikiPHPUnitCommand.php:42

FAILURES!
Tests: 176, Assertions: 577, Errors: 1.
Comment 1 Antoine "hashar" Musso (WMF) 2014-06-30 14:08:39 UTC
We really need tests to pass when all wmf extensions are installed together. That is preventing us from progression toward the HHVM migrating. Raising priority to High.
Comment 2 Gerrit Notification Bot 2014-07-18 00:24:24 UTC
Change 147349 had a related patch set uploaded by MaxSem:
HHVM compatibility: objects don't have array-like interface

https://gerrit.wikimedia.org/r/147349
Comment 3 Gerrit Notification Bot 2014-07-18 00:30:50 UTC
Change 147349 merged by jenkins-bot:
HHVM compatibility: objects don't have array-like interface

https://gerrit.wikimedia.org/r/147349

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links