Last modified: 2014-07-07 18:03:06 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T69598, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 67598 - EducationProgram dies if cldr is required after it
EducationProgram dies if cldr is required after it
Product: MediaWiki extensions
Classification: Unclassified
EducationProgram (Other open bugs)
All All
: High normal (vote)
: ---
Assigned To: Antoine "hashar" Musso (WMF)
Depends on:
Blocks: 67216
  Show dependency treegraph
Reported: 2014-07-07 15:39 UTC by Antoine "hashar" Musso (WMF)
Modified: 2014-07-07 18:03 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description Antoine "hashar" Musso (WMF) 2014-07-07 15:39:25 UTC
EducationProgram dies whenever it is missing the cldr extension which it relies on.  To run unit tests in Jenkins, we clone the extensions and have them loaded using scandir() which can yield EducationProgram before cldr.  The tests thus abort because EducationProgram.php is loaded first.

Seems the EducationProgram entry points does do that much and we have a SetupAfterCache hook in Setup.php  which could be used to implement the check.  The hook run after LocalSettings and all require_once(extensions/*) has been  completed so that should be safe.

That prevents us from enrolling EducationProgram in a massive jenkins job that tests all extensions together (bug 67216).
Comment 1 Gerrit Notification Bot 2014-07-07 15:45:36 UTC
Change 144464 had a related patch set uploaded by Hashar:
Delay check of cldr presence after Setup
Comment 2 Antoine "hashar" Musso (WMF) 2014-07-07 15:48:51 UTC
High because that prevent us from running tests properly and blocks somehow HHVM progress.
Comment 3 Gerrit Notification Bot 2014-07-07 17:07:06 UTC
Change 144464 merged by jenkins-bot:
Delay check of cldr presence after Setup
Comment 4 Antoine "hashar" Musso (WMF) 2014-07-07 18:03:06 UTC
The EducationProgram tests are now runnable yeah!  There is one test failing but it is unrelated ( )  Filled as bug 67608.

Note You need to log in before you can comment on or make changes to this bug.