Last modified: 2014-11-12 15:14:19 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67895, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 65895 - OAI does not pass Jenkins tests (sqlite compatibility)
OAI does not pass Jenkins tests (sqlite compatibility)
Status: PATCH_TO_REVIEW
Product: MediaWiki extensions
Classification: Unclassified
OAI (Other open bugs)
unspecified
All All
: Low normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: sqlite 65874 67216
  Show dependency treegraph
 
Reported: 2014-05-29 15:43 UTC by Antoine "hashar" Musso (WMF)
Modified: 2014-11-12 15:14 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Antoine "hashar" Musso (WMF) 2014-05-29 15:43:31 UTC
The OAI repository tests can be run in Jenkins because the extension is missing an entry point and is not compatible with sqlite.
Comment 1 Gerrit Notification Bot 2014-05-29 15:44:20 UTC
Change 136107 had a related patch set uploaded by Hashar:
Ignore OAI unit tests

https://gerrit.wikimedia.org/r/136107
Comment 2 Gerrit Notification Bot 2014-05-29 15:45:09 UTC
Change 136107 merged by jenkins-bot:
Ignore OAI unit tests

https://gerrit.wikimedia.org/r/136107
Comment 3 Gerrit Notification Bot 2014-05-29 15:45:53 UTC
Change 136105 had a related patch set uploaded by Hashar:
Adds OAI.php default entry for unit tests

https://gerrit.wikimedia.org/r/136105
Comment 4 Gerrit Notification Bot 2014-05-30 21:44:37 UTC
Change 136105 merged by jenkins-bot:
Adds OAI.php default entry for unit tests

https://gerrit.wikimedia.org/r/136105
Comment 5 Antoine "hashar" Musso (WMF) 2014-06-30 14:14:04 UTC
We really need tests to pass when all wmf extensions are installed together. That is preventing us from progression toward the HHVM migrating. Raising priority to High.
Comment 6 Antoine "hashar" Musso (WMF) 2014-07-08 08:51:16 UTC
Not sure how to fix that one. The OAI `updates` table has a `ut_page` as a primary key and `ut_sequence` with auto_increment.  Seems SQLite only supports auto_increment on primary key.

OAI is quite stable, does not have any tests and is supposed to be phased out eventually. Thus I am lowering the priority of this bug.
Comment 7 Sam Reed (reedy) 2014-07-08 10:29:08 UTC
There seems to be quite a bit of functionality in the extension we don't use. There isn't an updates table in production...

mysql:wikiadmin@db1038 [oai]> show tables;
+---------------+
| Tables_in_oai |
+---------------+
| oaiaudit      |
| oaiuser       |
+---------------+
2 rows in set (0.00 sec)

mysql:wikiadmin@db1038 [oai]>
Comment 8 Sam Reed (reedy) 2014-07-08 15:57:30 UTC
Updates table is on each wiki, not in the oai database

harvest table looks unused
Comment 9 Max Semenik 2014-07-18 10:32:14 UTC
What's the issue here, this extension doesn't even have tests? If you want schema updates to work, fine, but it's not blocking the migration in any way because Jenkins will test the DB and schema update method not used in production.
Comment 10 Gerrit Notification Bot 2014-07-25 00:18:29 UTC
Change 149200 had a related patch set uploaded by MaxSem:
Add SQLite support to make Jenkins happy

https://gerrit.wikimedia.org/r/149200
Comment 11 Gerrit Notification Bot 2014-09-18 18:11:46 UTC
Change 149200 abandoned by MaxSem:
Add SQLite support to make Jenkins happy

https://gerrit.wikimedia.org/r/149200
Comment 12 Andre Klapper 2014-11-12 15:14:19 UTC
All patches mentioned in this report were merged or abandoned - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links