Last modified: 2014-10-24 19:06:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T57886, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 55886 - CLDR breaks core timestamp tests
CLDR breaks core timestamp tests
Status: VERIFIED FIXED
Product: MediaWiki
Classification: Unclassified
Unit tests (Other open bugs)
unspecified
All All
: Normal normal (vote)
: 1.25.0 release
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 64430 67216
  Show dependency tree / graph
 
Reported: 2013-10-18 17:34 UTC by Chad H.
Modified: 2014-10-24 19:06 UTC (History)
12 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Chad H. 2013-10-18 17:34:15 UTC 
Without CLDR installed:

$ php phpunit.php includes/TimestampTest.php 
PHPUnit 3.7.27 by Sebastian Bergmann.

Configuration read from /www/mediawiki/core/tests/phpunit/suite.xml

.............................................

Time: 290 ms, Memory: 18.50Mb

OK (45 tests, 65 assertions)



With CLDR installed:

$ php phpunit.php includes/TimestampTest.php 
PHPUnit 3.7.27 by Sebastian Bergmann.

Configuration read from /www/mediawiki/core/tests/phpunit/suite.xml

........................FF..FFFFFFFF.........

Time: 298 ms, Memory: 19.25Mb

There were 10 failures:

1) TimestampTest::testHumanTimestamp with data set #0 ('20111231170000', '20120101000000', 'Offset|0', 'mdy', 'Yesterday at 17:00', '"Yesterday" across years')
"Yesterday" across years
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'Yesterday at 17:00'
+'7 hours ago'

/www/mediawiki/core/tests/phpunit/includes/TimestampTest.php:100
/www/mediawiki/core/tests/phpunit/MediaWikiTestCase.php:116
/www/mediawiki/core/tests/phpunit/MediaWikiPHPUnitCommand.php:80
/www/mediawiki/core/tests/phpunit/MediaWikiPHPUnitCommand.php:64

2) TimestampTest::testHumanTimestamp with data set #1 ('20120717190900', '20120717190929', 'Offset|0', 'mdy', 'just now', '"Just now"')
"Just now"
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'just now'
+'29 seconds ago'

/www/mediawiki/core/tests/phpunit/includes/TimestampTest.php:100
/www/mediawiki/core/tests/phpunit/MediaWikiTestCase.php:116
/www/mediawiki/core/tests/phpunit/MediaWikiPHPUnitCommand.php:80
/www/mediawiki/core/tests/phpunit/MediaWikiPHPUnitCommand.php:64

3) TimestampTest::testHumanTimestamp with data set #4 ('20120617190900', '20120717190900', 'Offset|0', 'mdy', 'June 17', 'Another month')
Another month
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'June 17'
+'1 month ago'

/www/mediawiki/core/tests/phpunit/includes/TimestampTest.php:100
/www/mediawiki/core/tests/phpunit/MediaWikiTestCase.php:116
/www/mediawiki/core/tests/phpunit/MediaWikiPHPUnitCommand.php:80
/www/mediawiki/core/tests/phpunit/MediaWikiPHPUnitCommand.php:64

4) TimestampTest::testHumanTimestamp with data set #5 ('19910130151500', '20120716193700', 'Offset|0', 'mdy', '15:15, January 30, 1991', 'Different year')
Different year
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'15:15, January 30, 1991'
+'21 years ago'

/www/mediawiki/core/tests/phpunit/includes/TimestampTest.php:100
/www/mediawiki/core/tests/phpunit/MediaWikiTestCase.php:116
/www/mediawiki/core/tests/phpunit/MediaWikiPHPUnitCommand.php:80
/www/mediawiki/core/tests/phpunit/MediaWikiPHPUnitCommand.php:64

5) TimestampTest::testHumanTimestamp with data set #6 ('20120101050000', '20120101080000', 'Offset|-360', 'mdy', 'Yesterday at 23:00', '"Yesterday" across years with time correction')
"Yesterday" across years with time correction
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'Yesterday at 23:00'
+'3 hours ago'

/www/mediawiki/core/tests/phpunit/includes/TimestampTest.php:100
/www/mediawiki/core/tests/phpunit/MediaWikiTestCase.php:116
/www/mediawiki/core/tests/phpunit/MediaWikiPHPUnitCommand.php:80
/www/mediawiki/core/tests/phpunit/MediaWikiPHPUnitCommand.php:64

6) TimestampTest::testHumanTimestamp with data set #7 ('20120714184300', '20120716184300', 'Offset|-420', 'mdy', 'Saturday at 11:43', 'Recent weekday with time correction')
Recent weekday with time correction
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'Saturday at 11:43'
+'2 days ago'

/www/mediawiki/core/tests/phpunit/includes/TimestampTest.php:100
/www/mediawiki/core/tests/phpunit/MediaWikiTestCase.php:116
/www/mediawiki/core/tests/phpunit/MediaWikiPHPUnitCommand.php:80
/www/mediawiki/core/tests/phpunit/MediaWikiPHPUnitCommand.php:64

7) TimestampTest::testHumanTimestamp with data set #8 ('20120714184300', '20120715040000', 'Offset|-420', 'mdy', '11:43', 'Today at another time with time correction')
Today at another time with time correction
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'11:43'
+'9 hours ago'

/www/mediawiki/core/tests/phpunit/includes/TimestampTest.php:100
/www/mediawiki/core/tests/phpunit/MediaWikiTestCase.php:116
/www/mediawiki/core/tests/phpunit/MediaWikiPHPUnitCommand.php:80
/www/mediawiki/core/tests/phpunit/MediaWikiPHPUnitCommand.php:64

8) TimestampTest::testHumanTimestamp with data set #9 ('20120617190900', '20120717190900', 'Offset|0', 'dmy', '17 June', 'Another month with dmy')
Another month with dmy
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'17 June'
+'1 month ago'

/www/mediawiki/core/tests/phpunit/includes/TimestampTest.php:100
/www/mediawiki/core/tests/phpunit/MediaWikiTestCase.php:116
/www/mediawiki/core/tests/phpunit/MediaWikiPHPUnitCommand.php:80
/www/mediawiki/core/tests/phpunit/MediaWikiPHPUnitCommand.php:64

9) TimestampTest::testHumanTimestamp with data set #10 ('20120617190900', '20120717190900', 'Offset|0', 'ISO 8601', '06-17', 'Another month with ISO-8601')
Another month with ISO-8601
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'06-17'
+'1 month ago'

/www/mediawiki/core/tests/phpunit/includes/TimestampTest.php:100
/www/mediawiki/core/tests/phpunit/MediaWikiTestCase.php:116
/www/mediawiki/core/tests/phpunit/MediaWikiPHPUnitCommand.php:80
/www/mediawiki/core/tests/phpunit/MediaWikiPHPUnitCommand.php:64

10) TimestampTest::testHumanTimestamp with data set #11 ('19910130151500', '20120716193700', 'Offset|0', 'ISO 8601', '1991-01-30T15:15:00', 'Different year with ISO-8601')
Different year with ISO-8601
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'1991-01-30T15:15:00'
+'21 years ago'

/www/mediawiki/core/tests/phpunit/includes/TimestampTest.php:100
/www/mediawiki/core/tests/phpunit/MediaWikiTestCase.php:116
/www/mediawiki/core/tests/phpunit/MediaWikiPHPUnitCommand.php:80
/www/mediawiki/core/tests/phpunit/MediaWikiPHPUnitCommand.php:64

FAILURES!
Tests: 45, Assertions: 55, Failures: 10.
Comment 1 Kartik Mistry 2013-10-19 08:50:46 UTC 
Confirmed.
Comment 2 Kartik Mistry 2013-10-19 09:11:34 UTC 
Important difference between 2013.07 and 2013.09 releases here is,

+$wgHooks['GetHumanTimestamp'][] = 'TimeUnits::onGetHumanTimestamp';

ie Tests were added only 2013.08 release (and they fails in 2013.08 too).
Comment 3 Niklas Laxström 2013-10-19 16:09:47 UTC 
The core tests should not run any hooks.

In addition it should perhaps be clarified what the getHumanTimestamp is expected to return. I've noticed some confusion and mixed expectations between absolute and relative expressions.
Comment 4 Marcin Cieślak 2013-12-05 10:58:19 UTC 
Can we skip testHumanTimestamp for now? Submitted gerrit change I161256bb46f6821b2223eff7ac85b1c80660b0c0 for this.
Comment 5 Nemo 2014-07-26 23:34:27 UTC 
Just got this as well.

1) MWTimestampTest::testHumanTimestamp with data set #0 ('20111231170000', '20120101000000', 'Offset|0', 'mdy', 'Yesterday at 17:00', '"Yesterday" across years')
"Yesterday" across years
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'Yesterday at 17:00'
+'7 hours ago'

/srv/vagrant/mediawiki/tests/phpunit/includes/MWTimestampTest.php:142
/srv/vagrant/mediawiki/tests/phpunit/MediaWikiTestCase.php:133
/srv/vagrant/mediawiki/tests/phpunit/MediaWikiPHPUnitCommand.php:42
/srv/vagrant/mediawiki/tests/phpunit/phpunit.php:160

2) MWTimestampTest::testHumanTimestamp with data set #1 ('20120717190900', '20120717190929', 'Offset|0', 'mdy', 'just now', '"Just now"')
"Just now"
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'just now'
+'29 seconds ago'

/srv/vagrant/mediawiki/tests/phpunit/includes/MWTimestampTest.php:142
/srv/vagrant/mediawiki/tests/phpunit/MediaWikiTestCase.php:133
/srv/vagrant/mediawiki/tests/phpunit/MediaWikiPHPUnitCommand.php:42
/srv/vagrant/mediawiki/tests/phpunit/phpunit.php:160

3) MWTimestampTest::testHumanTimestamp with data set #4 ('20120617190900', '20120717190900', 'Offset|0', 'mdy', 'June 17', 'Another month')
Another month
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'June 17'
+'1 month ago'

/srv/vagrant/mediawiki/tests/phpunit/includes/MWTimestampTest.php:142
/srv/vagrant/mediawiki/tests/phpunit/MediaWikiTestCase.php:133
/srv/vagrant/mediawiki/tests/phpunit/MediaWikiPHPUnitCommand.php:42
/srv/vagrant/mediawiki/tests/phpunit/phpunit.php:160

4) MWTimestampTest::testHumanTimestamp with data set #5 ('19910130151500', '20120716193700', 'Offset|0', 'mdy', '15:15, January 30, 1991', 'Different year')
Different year
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'15:15, January 30, 1991'
+'21 years ago'

/srv/vagrant/mediawiki/tests/phpunit/includes/MWTimestampTest.php:142
/srv/vagrant/mediawiki/tests/phpunit/MediaWikiTestCase.php:133
/srv/vagrant/mediawiki/tests/phpunit/MediaWikiPHPUnitCommand.php:42
/srv/vagrant/mediawiki/tests/phpunit/phpunit.php:160

5) MWTimestampTest::testHumanTimestamp with data set #6 ('20120101050000', '20120101080000', 'Offset|-360', 'mdy', 'Yesterday at 23:00', '"Yesterday" across years with time correction')
"Yesterday" across years with time correction
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'Yesterday at 23:00'
+'3 hours ago'

/srv/vagrant/mediawiki/tests/phpunit/includes/MWTimestampTest.php:142
/srv/vagrant/mediawiki/tests/phpunit/MediaWikiTestCase.php:133
/srv/vagrant/mediawiki/tests/phpunit/MediaWikiPHPUnitCommand.php:42
/srv/vagrant/mediawiki/tests/phpunit/phpunit.php:160

6) MWTimestampTest::testHumanTimestamp with data set #7 ('20120714184300', '20120716184300', 'Offset|-420', 'mdy', 'Saturday at 11:43', 'Recent weekday with time correction')
Recent weekday with time correction
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'Saturday at 11:43'
+'2 days ago'

/srv/vagrant/mediawiki/tests/phpunit/includes/MWTimestampTest.php:142
/srv/vagrant/mediawiki/tests/phpunit/MediaWikiTestCase.php:133
/srv/vagrant/mediawiki/tests/phpunit/MediaWikiPHPUnitCommand.php:42
/srv/vagrant/mediawiki/tests/phpunit/phpunit.php:160

7) MWTimestampTest::testHumanTimestamp with data set #8 ('20120714184300', '20120715040000', 'Offset|-420', 'mdy', '11:43', 'Today at another time with time correction')
Today at another time with time correction
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'11:43'
+'9 hours ago'

/srv/vagrant/mediawiki/tests/phpunit/includes/MWTimestampTest.php:142
/srv/vagrant/mediawiki/tests/phpunit/MediaWikiTestCase.php:133
/srv/vagrant/mediawiki/tests/phpunit/MediaWikiPHPUnitCommand.php:42
/srv/vagrant/mediawiki/tests/phpunit/phpunit.php:160

8) MWTimestampTest::testHumanTimestamp with data set #9 ('20120617190900', '20120717190900', 'Offset|0', 'dmy', '17 June', 'Another month with dmy')
Another month with dmy
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'17 June'
+'1 month ago'

/srv/vagrant/mediawiki/tests/phpunit/includes/MWTimestampTest.php:142
/srv/vagrant/mediawiki/tests/phpunit/MediaWikiTestCase.php:133
/srv/vagrant/mediawiki/tests/phpunit/MediaWikiPHPUnitCommand.php:42
/srv/vagrant/mediawiki/tests/phpunit/phpunit.php:160

9) MWTimestampTest::testHumanTimestamp with data set #10 ('20120617190900', '20120717190900', 'Offset|0', 'ISO 8601', '06-17', 'Another month with ISO-8601')
Another month with ISO-8601
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'06-17'
+'1 month ago'

/srv/vagrant/mediawiki/tests/phpunit/includes/MWTimestampTest.php:142
/srv/vagrant/mediawiki/tests/phpunit/MediaWikiTestCase.php:133
/srv/vagrant/mediawiki/tests/phpunit/MediaWikiPHPUnitCommand.php:42
/srv/vagrant/mediawiki/tests/phpunit/phpunit.php:160

10) MWTimestampTest::testHumanTimestamp with data set #11 ('19910130151500', '20120716193700', 'Offset|0', 'ISO 8601', '1991-01-30T15:15:00', 'Different year with ISO-8601')
Different year with ISO-8601
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'1991-01-30T15:15:00'
+'21 years ago'

/srv/vagrant/mediawiki/tests/phpunit/includes/MWTimestampTest.php:142
/srv/vagrant/mediawiki/tests/phpunit/MediaWikiTestCase.php:133
/srv/vagrant/mediawiki/tests/phpunit/MediaWikiPHPUnitCommand.php:42
/srv/vagrant/mediawiki/tests/phpunit/phpunit.php:160
Comment 6 Gerrit Notification Bot 2014-10-15 14:52:23 UTC 
Change 166751 had a related patch set uploaded by Umherirrender:
Avoid running of hooks when running MWTimestampTest

https://gerrit.wikimedia.org/r/166751
Comment 7 Gerrit Notification Bot 2014-10-23 19:18:23 UTC 
Change 166751 merged by jenkins-bot:
Avoid running of hooks when running MWTimestampTest

https://gerrit.wikimedia.org/r/166751
Comment 8 Antoine "hashar" Musso (WMF) 2014-10-24 19:06:53 UTC 
Thanks !
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links