Last modified: 2014-07-29 00:29:57 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T70634, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 68634 - Exception: .agora-field-styling is undefined: failed at `.agora-field-styling();`
Exception: .agora-field-styling is undefined: failed at `.agora-field-styling...
Product: MediaWiki extensions
Classification: Unclassified
UrlShortener (Other open bugs)
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
Depends on:
Blocks: 67216
  Show dependency treegraph
Reported: 2014-07-26 23:25 UTC by Nemo
Modified: 2014-07-29 00:29 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description Nemo 2014-07-26 23:25:07 UTC
6) /srv/vagrant/mediawiki/extensions/UrlShortener/less/ext.urlShortener.special.less in the "ext.urlShortener.special.styles" module
Exception: .agora-field-styling is undefined: failed at `.agora-field-styling();` /srv/vagrant/mediawiki/extensions/UrlShortener/less/ext.urlShortener.special.less on line 12

Comment 1 Bartosz Dziewoński 2014-07-26 23:32:16 UTC
Hmph, somebody used that? It was undocumented and not intended for public consumption, Jon and I removed it a few weeks ago.
Comment 2 Jon 2014-07-27 23:38:22 UTC
Yeh. it's also styling this on 2 ids :-S

This is a good example of why mixins without parameter names are bad - this causes 3 sets of duplicate css.

The url shortner should be using mw-ui-button and mw-ui-input [1] when available.

Comment 3 Kunal Mehta (Legoktm) 2014-07-28 05:47:05 UTC
So, what's the migration plan? Undocumented or not, it ended up in the 1.23 release, so it got used (the extension is live on 2 wikifarms at least).

(In reply to Jon from comment #2)
> The url shortner should be using mw-ui-button and mw-ui-input [1] when
> available.
> [1]

Linked change hasn't been merged yet, so not really useful...
Comment 4 Jon 2014-07-28 06:03:04 UTC
This line of css should be removed. I'm not sure why it was using that mixin in the first place.

I suspect it was trying to style an input in the mediawiki ui style.
If it wants to use that style it will need to wait for that patch to be merged so help getting it merged appreciated.
Comment 5 Antoine "hashar" Musso (WMF) 2014-07-28 09:29:17 UTC
Is that UrlShortener using a CSS definition that get removed from core?
Comment 6 Gerrit Notification Bot 2014-07-28 17:14:00 UTC
Change 149902 had a related patch set uploaded by Jdlrobson:
Fix LESS exception
Comment 7 Jon 2014-07-28 17:21:06 UTC
Too much talking :P
Above fixes it.
There are follow ups which can be merged without dependencies that fix the styling.
Comment 8 Gerrit Notification Bot 2014-07-28 19:19:18 UTC
Change 149902 merged by Bartosz Dziewoński:
Fix LESS exception
Comment 9 Kunal Mehta (Legoktm) 2014-07-29 00:29:57 UTC
Thanks :)

Note You need to log in before you can comment on or make changes to this bug.