Last modified: 2014-01-07 11:01:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59866, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 57866 - Causes "Incorrect password entered" error when the account is globally locked
Causes "Incorrect password entered" error when the account is globally locked
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CentralAuth (Other open bugs)
master
All All
: Normal normal (vote)
: ---
Assigned To: Brad Jorsch
:
: 53755 57791 (view as bug list)
Depends on:
Blocks: SWMT
  Show dependency treegraph
 
Reported: 2013-12-02 18:43 UTC by Brad Jorsch
Modified: 2014-01-07 11:01 UTC (History)
11 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Brad Jorsch 2013-12-02 18:43:26 UTC
When the account is globally locked, CentralAuth will currently fail the
password check leading to a message "Incorrect password entered." This 
is misleading and causes unnecessary bug reports such as bug 53755 and 
bug 57791.
Comment 1 Gerrit Notification Bot 2013-12-02 18:43:53 UTC
Change 98568 had a related patch set uploaded by Anomie:
Correct failure message when account is locked

https://gerrit.wikimedia.org/r/98568
Comment 2 Brad Jorsch 2013-12-02 18:46:59 UTC
*** Bug 53755 has been marked as a duplicate of this bug. ***
Comment 3 Brad Jorsch 2013-12-02 18:47:02 UTC
*** Bug 57791 has been marked as a duplicate of this bug. ***
Comment 4 PiRSquared17 2013-12-02 19:06:35 UTC
Would it be possible to display a link to the log and how to appeal a lock?
Comment 5 Brad Jorsch 2013-12-02 19:31:31 UTC
That's likely out of place here. You could probably do it through customizing the new message on the local wiki.
Comment 6 PiRSquared17 2013-12-02 19:32:42 UTC
(In reply to comment #5)
> That's likely out of place here. You could probably do it through customizing
> the new message on the local wiki.

Can this be done for all 700+ Wikimedia wikis?
Comment 7 billinghurst 2013-12-02 22:04:00 UTC
I would hope that there is a capacity for this to be a single global message, and one that would be stored on translatewiki as a Wikimedia message, ie. a master message that is translated.  Locks are only performed by stewards at the WMF, and having a series of localised messages that local admins can amend is just going to be confusing compared with having a consistent message (that stewards wish to have in place for stewards needs) and have that translated to each language.  To my understanding, the scripting for messaging for global block has been suitably amended.
Comment 8 PiRSquared17 2013-12-03 16:32:11 UTC
If a link to the log and to [[m:SRG]] is not possible, how about just displaying the log entry and reason for the lock?
Comment 9 Gerrit Notification Bot 2014-01-05 14:15:19 UTC
Change 98568 merged by jenkins-bot:
Correct failure message when account is locked

https://gerrit.wikimedia.org/r/98568
Comment 10 Marius Hoch 2014-01-05 14:16:06 UTC
Approved the patch
Comment 11 Bsadowski1 2014-01-07 02:10:10 UTC
The CentralAuth system was working as intended. The two bug reports you mentioned were because of actions of user (in this case, steward) error. Will this cause unintentional bugs?
Comment 12 Brad Jorsch 2014-01-07 04:10:35 UTC
(In reply to comment #11)
> The CentralAuth system was working as intended.

Only if by "working as intended" you mean "giving a misleading error message that sent people in the wrong direction trying to figure out why the user couldn't log in".

The only thing changed here was the error message displayed to the user when their account is globally locked.
Comment 13 Bsadowski1 2014-01-07 04:50:42 UTC
No, I meant that *technically* it was working as it should have been. Locking has been primarily been used to keep out spambots and long-term abusers/vandals. What does new one look like, by the way?
Comment 14 Andre Klapper 2014-01-07 08:33:53 UTC
(In reply to comment #13)
> What does new one look like, by the way?

https://gerrit.wikimedia.org/r/98568 or wait a few days.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links