Last modified: 2014-03-19 19:35:19 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 45469 - The <Centralauth-error-locked> message sucks and needs improvement
The <Centralauth-error-locked> message sucks and needs improvement
Status: ASSIGNED
Product: MediaWiki extensions
Classification: Unclassified
CentralAuth (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: i18n
Depends on:
Blocks: messages SWMT
  Show dependency treegraph
 
Reported: 2013-02-27 01:00 UTC by James Forrester
Modified: 2014-03-19 19:35 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description James Forrester 2013-02-27 01:00:02 UTC
The <Centralauth-error-locked> message sucks and needs improvement - it currently reads:

  You cannot edit because your account is locked.

This compares poorly to <Globalblocking-blocked> in terms of giving users somewhere to go:

  Your IP address $5 has been blocked on all wikis by $1 ($2). The reason given was "$3". The block $4.

(This is being changed right now anyway.)
Comment 1 PiRSquared17 2013-12-02 18:08:20 UTC
(In reply to comment #0)
> The <Centralauth-error-locked> message sucks and needs improvement - it
> currently reads:
> 
>   You cannot edit because your account is locked.
> 
> This compares poorly to <Globalblocking-blocked> in terms of giving users
> somewhere to go:
> 
>   Your IP address $5 has been blocked on all wikis by $1 ($2). The reason
> given
> was "$3". The block $4.
> 
> (This is being changed right now anyway.)

Does the extension even give an error when logging in? I think it's just the incorrect passwd message.
Comment 2 MZMcBride 2013-12-15 03:06:22 UTC
James: should this bug continue to be assigned to you?
Comment 3 MZMcBride 2014-01-06 02:14:05 UTC
(In reply to comment #2)
> James: should this bug continue to be assigned to you?

Bump.

And did <https://gerrit.wikimedia.org/r/98568> fix this bug? Can someone check?
Comment 4 PiRSquared17 2014-02-27 03:19:26 UTC
(In reply to MZMcBride from comment #3)
> (In reply to comment #2)
> > James: should this bug continue to be assigned to you?
> 
> Bump.
> 
> And did <https://gerrit.wikimedia.org/r/98568> fix this bug? Can someone
> check?

This bug is about Centralauth-error-locked, not Centralauth-login-error-locked.  Also, that did not include any detailed info like the reason for being locked.
Comment 5 PiRSquared17 2014-02-27 03:19:55 UTC
(In reply to James Forrester from comment #0)
Are you still working on this?
Comment 6 Nemo 2014-02-27 08:55:27 UTC
(In reply to PiRSquared17 from comment #4)
> This bug is about Centralauth-error-locked, not
> Centralauth-login-error-locked.  Also, that did not include any detailed
> info like the reason for being locked.

Can you submit a patch please?
Comment 7 PiRSquared17 2014-02-27 16:27:32 UTC
(In reply to Nemo from comment #6)
> (In reply to PiRSquared17 from comment #4)
> > This bug is about Centralauth-error-locked, not
> > Centralauth-login-error-locked.  Also, that did not include any detailed
> > info like the reason for being locked.
> 
> Can you submit a patch please?

This is nontrivial, like bug 61548.  The lock reasons are not stored in a central location currently.  Using the current scheme, we would need to query every wiki (since locks can be from any wiki).  Perhaps it would be better to create a central location for the globalauth logs or at least the current locks (maybe in globaluser table?).

James, are you still interested in this?
Comment 8 Nemo 2014-02-27 16:30:20 UTC
There is a bug about restricting changes of global groups rights and membership to the central wiki; there is probably also one for locks. If that's a requirement for this bug, let's add it to blockers and get all of them done at once.
Comment 9 PiRSquared17 2014-03-01 15:47:00 UTC
A temporary fix would be to only look on the "central wiki", and just give the current message if it's not found there.

(In reply to Nemo from comment #8)
> There is a bug about restricting changes of global groups rights and
> membership to the central wiki; there is probably also one for locks. If
> that's a requirement for this bug, let's add it to blockers and get all of
> them done at once.

Ticket link?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links