Last modified: 2014-06-10 19:54:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T49076, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 47076 - Upgrade jQuery UI from 1.8 to 1.9
Upgrade jQuery UI from 1.8 to 1.9
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
1.22.0
All All
: Low normal with 1 vote (vote)
: 1.24.0 release
Assigned To: Krinkle
:
: 65520 66376 (view as bug list)
Depends on:
Blocks: jqmigrate-$.browser 66365
  Show dependency treegraph
 
Reported: 2013-04-10 14:33 UTC by Niklas Laxström
Modified: 2014-06-10 19:54 UTC (History)
13 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Niklas Laxström 2013-04-10 14:33:24 UTC
http://jqueryui.com/download/ says 1.10 is stable and 1.9 is legacy, MediaWiki seems to have 1.8! I spent a while figuring out why some parts of jquery.ui.position were not working, until I checked out the version.
Comment 1 Niklas Laxström 2013-04-10 15:22:41 UTC
Had to work around this in Translate: https://gerrit.wikimedia.org/r/58521
Comment 2 Michael M. 2014-05-20 11:18:02 UTC
*** Bug 65520 has been marked as a duplicate of this bug. ***
Comment 3 Krinkle 2014-05-21 14:47:12 UTC
Unlike jQuery core, jQuery UI has quite a few changes that require modification to existing code to remain compatible.

Almost exclusively simple changes (e.g. result of improving the API). Afaik no things have been dropped or made difficult, but it requires changes.

And we have a shitload of code out there, including the community, so we'll probably need to give them more than 3 weeks (like we did with jQuery core) to do migration.

And.. no official legacy layer to smooth migration. So, not sure how we're going to tackle this.

Upgrade guides:
* http://jqueryui.com/upgrade-guide/1.8/
* http://jqueryui.com/upgrade-guide/1.8.4/
* http://jqueryui.com/upgrade-guide/1.8.5/
* http://jqueryui.com/upgrade-guide/1.8.6/
* http://jqueryui.com/upgrade-guide/1.8.7/
* http://jqueryui.com/upgrade-guide/1.8.11/
* http://jqueryui.com/upgrade-guide/1.9/
* http://jqueryui.com/upgrade-guide/1.10/
Comment 4 Michael M. 2014-05-22 08:13:47 UTC
(In reply to Krinkle from comment #3)

> And.. no official legacy layer to smooth migration. So, not sure how we're
> going to tackle this.

http://jqueryui.com/upgrade-guide/1.9/ says: "Although the redesigns introduce breaking changes, 1.9 maintains full compatibility with the 1.8 API by default."

> Upgrade guides:
> * http://jqueryui.com/upgrade-guide/1.8/
> * http://jqueryui.com/upgrade-guide/1.8.4/
> * http://jqueryui.com/upgrade-guide/1.8.5/
> * http://jqueryui.com/upgrade-guide/1.8.6/
> * http://jqueryui.com/upgrade-guide/1.8.7/
> * http://jqueryui.com/upgrade-guide/1.8.11/

These links are irrelevant, as MediaWiki already uses 1.8.24.

> No longer blocks: 65399

You are aware of the fact that jquery.ui 1.8.x makes excessive use of $.browser, which is deprecated and only provided by jquery.migrate?
Comment 5 Adrian Lang 2014-06-04 06:22:35 UTC
Wikibase makes extensive use of jQuery UI and I'd love to be able to work with a newer version. If the migration indeed is very hard, we might try to provide both versions side-by-side instead?
Comment 6 Krinkle 2014-06-04 20:54:02 UTC
(In reply to Michael M. from comment #4)
> (In reply to Krinkle from comment #3)
> 
> > And.. no official legacy layer to smooth migration. So, not sure how we're
> > going to tackle this.
> 
> http://jqueryui.com/upgrade-guide/1.9/ says: "Although the redesigns
> introduce breaking changes, 1.9 maintains full compatibility with the 1.8
> API by default."

Yeah, I knew that already actually. Forgot about that.

I spoke with Scott Gonzalez and he also re-assured me that really there is nothing stopping us from upgrading to 1.9.

The only major thing being dropped in jQuery UI 1.9 is support for the jQuery UI 1.7 API, which MediaWiki never supported to begin with (jQuery UI 1.8 is the first version that ever shipped with MediaWiki).
Comment 7 Gerrit Notification Bot 2014-06-04 22:20:55 UTC
Change 137471 had a related patch set uploaded by Krinkle:
Upgrade jQuery UI from 1.8.24 to 1.9.2

https://gerrit.wikimedia.org/r/137471
Comment 8 Matthew Flaschen 2014-06-06 23:23:02 UTC
Adding as a blocker on $.browser bug, per Michael M. (confirmed by grep).
Comment 9 Gerrit Notification Bot 2014-06-09 16:01:53 UTC
Change 137471 merged by jenkins-bot:
Upgrade jQuery UI from 1.8.24 to 1.9.2

https://gerrit.wikimedia.org/r/137471
Comment 10 Matthew Flaschen 2014-06-10 19:54:38 UTC
*** Bug 66376 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links