Last modified: 2014-06-10 12:47:59 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68365, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 66365 - Lightboxes: cannot read property msie of undefined (jquery.ui)


Summary:	Lightboxes: cannot read property msie of undefined (jquery.ui)

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	JavaScript (Other open bugs)
Version:	1.24rc
Hardware:	All All

Importance:	High major (vote)
Target Milestone:	1.24.0 release
Assigned To:	Krinkle

URL:
Whiteboard:
Keywords:

Depends on:	47076
Blocks:	jqmigrate-$.browser
	Show dependency tree / graph

Reported:	2014-06-09 10:47 UTC by Florian
Modified:	2014-06-10 12:47 UTC (History)
CC List:	3 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Console output (87.56 KB, image/png) 2014-06-09 10:47 UTC, Florian	Details
Add an attachment (proposed patch, testcase, etc.)

Description Florian 2014-06-09 10:47:36 UTC

Created attachment 15598 [details]
Console output

On actual MW and Thanks master git branch if i click on "thanks" (Confirmation is enabled) i become a simple grey overlay and the error in console:
Uncaught TypeError: Cannot read property 'msie' of undefined

This may be because of upgrade from jQuery 1.8 to 1.11.x (see http://www.mail-archive.com/wikitech-l@lists.wikimedia.org/msg75735.html), $.browser was deprecated and removed since version 1.9 (see http://api.jquery.com/jQuery.browser/)

So, the thanks function doesn't work for me in actual master versions (maybe other extensions/functions are broken too).

Information about wiki installation:
MW: 1.24alpha (c812315) 21:47, 8 June 2014
PHP: 5.5.3-1ubuntu2.3 (apache2handler)
MySQL: 5.5.37-0ubuntu0.13.10.1

installed Extensions:
Echo	– (d4acf1d) 19:53, 4 June 2014
MobileFrontend	– (51a2297) 19:57, 8 June 2014
Thanks	1.2.0 (08c6fb5) 19:58, 8 June 2014

Comment 1 Jesús Martínez Novo (Ciencia Al Poder) 2014-06-09 11:21:30 UTC

Any access to jquery.ui.dialog is now broken in master :S

Comment 2 Gerrit Notification Bot 2014-06-09 12:02:11 UTC

Change 138325 had a related patch set uploaded by Florianschmidtwelzow:
Replace use of jQuery.browser

https://gerrit.wikimedia.org/r/138325

Comment 3 Gerrit Notification Bot 2014-06-09 12:10:41 UTC

Change 138325 abandoned by Florianschmidtwelzow:
Replace use of jQuery.browser

Reason:
Much better to upgrade the libary:
I0e10b42fb7c25b9d4704719f21c44c08f36ddfa7

https://gerrit.wikimedia.org/r/138325

Comment 4 Florian 2014-06-09 12:11:01 UTC

See:
https://gerrit.wikimedia.org/r/#/c/137471/

Comment 5 Bartosz Dziewoński 2014-06-09 16:02:13 UTC

Should be fixed by upgrading jQuery UI.

Note You need to log in before you can comment on or make changes to this bug.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links