Last modified: 2014-06-10 19:54:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68376, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 66376 - test2wiki: "Link" and other lightboxes completely empty
test2wiki: "Link" and other lightboxes completely empty
Status: RESOLVED DUPLICATE of bug 47076
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
1.24rc
All All
: Highest normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: jqmigrate-$.browser
  Show dependency treegraph
 
Reported: 2014-06-09 16:37 UTC by Chris McMahon
Modified: 2014-06-10 19:54 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Link lightbox is empty (490.24 KB, image/png)
2014-06-09 16:37 UTC, Chris McMahon
Details

Description Chris McMahon 2014-06-09 16:37:10 UTC
Created attachment 15603 [details]
Link lightbox is empty

On any page on http://test2.wikipedia.org

In the wikitext editor

type some text; highlight the text; click the link icon

resulting lightbox should contain "Insert Link" interface with "Target page" and "Text to display" but instead is completely empty. 

Note:  not see on mediawiki.org, but possibly a risk of it happening there.
Comment 1 Andre Klapper 2014-06-10 11:17:53 UTC
For me not only adding a link in wiki editor is completely broken; same for other buttons that I tried - no interface shown.

Console says:
   TypeError: $.browser is undefined      load.php:31

That specific line says "if($.browser.msie)".  For browser detection, jQuery.client (https://doc.wikimedia.org/mediawiki-core/master/js/#!/api/jQuery.client) is recommended instead.
Comment 2 Florian 2014-06-10 12:47:07 UTC
Maybe a dublicate of:
https://bugzilla.wikimedia.org/show_bug.cgi?id=66365
Comment 3 Andre Klapper 2014-06-10 13:09:35 UTC
Florian: Yeah, likely (thanks for catching that). 
I'll let Krinkle (or so) decide who knows way better than me...
Comment 4 Chris McMahon 2014-06-10 14:48:11 UTC
I wonder why this problem is on test2wiki now but not on mw.o.  Seems risky.
Comment 5 Florian 2014-06-10 15:08:26 UTC
Maybe mw.org has enabled jquerymigrate?
Comment 6 Matthew Flaschen 2014-06-10 19:54:38 UTC
Line in question is part of jquery.ui.dialog.js (specifically, jQuery UI Dialog 1.8.24).  To get filenames, run in debug mode (https://www.mediawiki.org/wiki/ResourceLoader/Features#Debug_mode).  If there's already a question mark in the URL (as there is here, since it's an edit page), add '&debug=true' (no quotes) to the URL.  If there's no question mark yet, add '?debug=true' (no quotes).

Thus, this is a duplicate of bug 47076.  It will be fixed when jQuery UI 1.9 rolls out.

jQuery Migrate is specifically disabled on test2wiki, probably so such errors will show up there (eventually jQuery Migrate will be disabled everywhere, so we need to catch these errors now): https://git.wikimedia.org/blob/operations%2Fmediawiki-config/e9c79e0352c1536648140acf3133ab74b5d8ebb3/wmf-config%2FInitialiseSettings.php#L12464

*** This bug has been marked as a duplicate of bug 47076 ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links