Last modified: 2014-07-08 20:06:34 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68824, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 66824 - VisualEditor: Fix tabindexes in the citation dialog
VisualEditor: Fix tabindexes in the citation dialog
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2014-07-03
Assigned To: Alex Monk
:
: 67159 (view as bug list)
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-06-19 05:25 UTC by Matthew Flaschen
Modified: 2014-07-08 20:06 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Tabbing issue in Firefox (1.72 MB, video/ogg)
2014-06-27 19:14 UTC, Matthew Flaschen 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Matthew Flaschen 2014-06-19 05:25:53 UTC 
On English Wikipedia, tabbing in the citation dialog is broken.  To reproduce:

1. Edit an article with VE.
2. Choose 'News' from the Cite menu.
3. Click the first field.
4. Tab to try to get to the next field.

Focus goes to a help icon, and even tabbing repeatedly will not get it to leave that icon.
Comment 1 Alex Monk 2014-06-19 17:43:59 UTC 
It's supposed to go to the help icon (that was Gerrit change #137152 - bug 65474), but 'tabbing repeatedly will not get it to leave that icon' is WFM
Comment 2 James Forrester 2014-06-19 22:52:56 UTC 
Actually:

* in Firefox, the tabbing doesn't take you to the help icon (or delete icon), only in Chrome (instead it takes you to the next field);
* in neither can you tab to the "add field" button;
* when the add field panel opens your cursor doesn't open in the search field;
* when in the add field search box tabbing doesn't take you to the field options.

However, yeah, I can't replicate the original report – Matt, can you clarify?
Comment 3 Matthew Flaschen 2014-06-27 19:14:06 UTC 
Created attachment 15765 [details]
Tabbing issue in Firefox

I can still reproduce it.  I should have said, I tested in Iceweasel/Firefox 30.0 on Debian Wheezy.

I'm attaching a video.  It shows how I got there, and that it tabs to the help icon.  I tab multiple times and it sticks, though you can't see that in the video.
Comment 4 Alex Monk 2014-06-27 20:52:54 UTC 
Weird... I can replicate this in Firefox, but not Chrome.

I tried copying the inner HTML out of the dialog iframe and into a separate file - it worked there.
I also tried moving the tabindex attribute from the <a>s to their parent <div>s... That seems to work. Not sure why.

(I've been testing with any template which has TemplateData, btw - not specifically Cite stuff)
Comment 5 Gerrit Notification Bot 2014-06-27 20:53:52 UTC 
Change 142718 had a related patch set uploaded by Alex Monk:
Set tabindex for template dialog info/remove buttons on parent <div> rather than <a>

https://gerrit.wikimedia.org/r/142718
Comment 6 Gerrit Notification Bot 2014-06-30 18:18:09 UTC 
Change 142718 merged by jenkins-bot:
Set tabindex for template dialog info/remove buttons on parent <div> rather than <a>

https://gerrit.wikimedia.org/r/142718
Comment 7 Alex Monk 2014-06-30 18:20:26 UTC 
Well that's at least a workaround. I wonder if this might be an upstream bug...
Comment 8 James Forrester 2014-07-08 20:06:34 UTC 
*** Bug 67159 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links