Last modified: 2014-07-08 19:35:47 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67554, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 65554 - VisualEditor: [Regression] Can't tab to save form dialog buttons in Firefox
VisualEditor: [Regression] Can't tab to save form dialog buttons in Firefox
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2014-07-03
Assigned To: Alex Monk
:
: 67153 (view as bug list)
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-05-20 20:59 UTC by James Forrester
Modified: 2014-07-08 19:35 UTC (History)
4 users (show)

See Also:
Web browser: Firefox
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description James Forrester 2014-05-20 20:59:10 UTC 
Bug 50047 and bug 51918 have regressed for Firefox – possibly as a result of Ed's changes to how the buttons work? Yay for Firefox and its attitude to tab indexes.
Comment 1 Alex Monk 2014-06-30 16:51:35 UTC 
Looks like the same issue as bug 66824
Comment 2 Alex Monk 2014-06-30 17:02:05 UTC 
So adding this.reviewButton.$element.attr( 'tabindex', '0' ).find( 'a' ).removeAttr( 'tabindex' ); fixed this... Wtf firefox?
Comment 3 Gerrit Notification Bot 2014-06-30 17:21:46 UTC 
Change 143055 had a related patch set uploaded by Alex Monk:
Set tabindex on button <div> instead of <a>

https://gerrit.wikimedia.org/r/143055
Comment 4 Gerrit Notification Bot 2014-06-30 18:19:24 UTC 
Change 143055 merged by jenkins-bot:
Set tabindex on button <div> instead of <a>

https://gerrit.wikimedia.org/r/143055
Comment 5 Alex Monk 2014-06-30 18:21:28 UTC 
Well that's at least a workaround. I wonder if this might be an upstream bug...
Comment 6 James Forrester 2014-07-08 19:35:47 UTC 
*** Bug 67153 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links