Last modified: 2014-09-18 15:12:56 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59777, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 57777 - CSSMin::encodeImageAsDataURI() should be smarter about SVG images (tracking)
CSSMin::encodeImageAsDataURI() should be smarter about SVG images (tracking)
Status: NEW
Product: MediaWiki
Classification: Unclassified
ResourceLoader (Other open bugs)
unspecified
All All
: High enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: tracking
Depends on: 34812 63491 67341 71003
Blocks: tracking
  Show dependency treegraph
 
Reported: 2013-11-30 18:27 UTC by Bartosz Dziewoński
Modified: 2014-09-18 15:12 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Bartosz Dziewoński 2013-11-30 18:27:37 UTC
Thanks to the work of GCI students, we now have lots of SVG images in core (and lots more in extensions). However, they're usually somewhat pretty-formatted, with whitespace and comments.

CSSMin::encodeImageAsDataURI() should be smart about this in two ways:
* Not base64-encode plain ASCII text, just escape quotes and backslashes
* Strip whitespace and comments (and possibly apply other transformations)
Comment 1 Niklas Laxström 2013-11-30 18:32:44 UTC
Whitespace and comment stripping is unlikely to produce much gain. Stripping other unneeded stuff can produce big gains as we observed in ULS images.
Comment 2 Jatin 2014-02-10 11:59:57 UTC
(In reply to comment #1)
> Whitespace and comment stripping is unlikely to produce much gain. Stripping
> other unneeded stuff can produce big gains as we observed in ULS images.

I'm thinking of taking up this bug!!

Well what could be that other unneeded stuff that could  be striped ??
Comment 3 Gerrit Notification Bot 2014-03-03 16:16:26 UTC
Change 116490 had a related patch set uploaded by Deepali:
Handling svg images in CSSMin::encodeImageAsDataURI()

https://gerrit.wikimedia.org/r/116490
Comment 4 Matthew Flaschen 2014-07-01 00:52:41 UTC
Splitting this into two things:

* Optimizing SVGs (bug 34812)
* Whether to use base 64 (bug 67341)
Comment 5 Gerrit Notification Bot 2014-09-17 21:17:34 UTC
Change 116490 abandoned by Bartosz Dziewoński:
Handling svg images in CSSMin::encodeImageAsDataURI()

Reason:
No interest from uploader. Superseded by https://gerrit.wikimedia.org/r/161091

https://gerrit.wikimedia.org/r/116490

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links