Last modified: 2014-10-01 17:24:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T69341, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 67341 - CSSMin: Embed non-binary data URIs using plain text instead of base64
CSSMin: Embed non-binary data URIs using plain text instead of base64
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
ResourceLoader (Other open bugs)
1.24rc
All All
: Normal enhancement (vote)
: 1.25.0 release
Assigned To: Bartosz Dziewoński
:
Depends on:
Blocks: 57777
  Show dependency tree / graph
 
Reported: 2014-07-01 00:45 UTC by Matthew Flaschen
Modified: 2014-10-01 17:24 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Matthew Flaschen 2014-07-01 00:45:37 UTC 
Bartosz suggested that we look into using data URLs without base 64.  An example is http://jsfiddle.net/SJjJb/1332/ , a text-based one for SVG.

Some escaping is practically necessary (e.g. at least %23 for #).  It is not clear how much is required by either browser compatibility or the standard.

He mentioned http://software.hixie.ch/utilities/cgi/data/data as a library for this as well.

If the required escaping ends up inflating it (e.g. if we have to escape < and >), so we need to calculate (either in general, or in a case-by-case basis), which is the winner (base 64 or escaped text).
Comment 1 Gerrit Notification Bot 2014-09-17 21:16:59 UTC 
Change 161091 had a related patch set uploaded by Bartosz Dziewoński:
CSSMin: Do not base64-encode non-binary files when embedding

https://gerrit.wikimedia.org/r/161091
Comment 2 Gerrit Notification Bot 2014-09-30 21:49:30 UTC 
Change 161091 merged by jenkins-bot:
CSSMin: Do not base64-encode non-binary files when embedding

https://gerrit.wikimedia.org/r/161091
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links