Last modified: 2014-10-01 17:23:59 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T73003, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 71003 - CSSMin: Don't generate double rules for IE < 8 when embedding SVG files


Summary:	CSSMin: Don't generate double rules for IE < 8 when embedding SVG files

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	ResourceLoader (Other open bugs)
Version:	1.24rc
Hardware:	All All

Importance:	Low minor (vote)
Target Milestone:	1.25.0 release
Assigned To:	Bartosz Dziewoński

URL:
Whiteboard:
Keywords:	easy

Depends on:
Blocks:	57777
	Show dependency tree / graph

Reported:	2014-09-18 15:12 UTC by Bartosz Dziewoński
Modified:	2014-10-01 17:23 UTC (History)
CC List:	5 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Bartosz Dziewoński 2014-09-18 15:12:56 UTC

CSSMin doesn't need to generate double rules for IE<8 when embedding SVG files. IE<8 will not load SVG images anyway, so this just wastes space.

This if() in CSSMin.php probably should have a test added for SVG MIME type.

  if ( $embedData && $ruleWithEmbedded !== $ruleWithRemapped ) {
    return "$ruleWithEmbedded;$ruleWithRemapped!ie";
  } else {
    return $ruleWithRemapped;
  }

Comment 1 db [inactive,noenotif] 2014-09-18 18:51:08 UTC

Is that needed for Grade C browsers? Maybe remove support for IE7 there also.

Comment 2 Bartosz Dziewoński 2014-09-18 18:52:48 UTC

We only dropped JS for IE 6 and 7, we still support them for basic CSS.

Comment 3 Gerrit Notification Bot 2014-09-22 12:38:34 UTC

Change 161932 had a related patch set uploaded by Bartosz Dziewoński:
CSSMin: Don't generate double rules for IE < 8 when embedding SVG files

https://gerrit.wikimedia.org/r/161932

Comment 4 Gerrit Notification Bot 2014-09-30 22:01:48 UTC

Change 161932 merged by jenkins-bot:
CSSMin: Don't generate double rules for IE < 8 when embedding SVG files

https://gerrit.wikimedia.org/r/161932

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links