Last modified: 2014-11-19 21:50:06 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53205, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 51205 - VisualEditor: Matching pages list in link dialog should support right-click / ctrl+click to open page in a new window/tab
VisualEditor: Matching pages list in link dialog should support right-click /...
Status: VERIFIED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Low enhancement
: VE-deploy-2014-11-12 (1.25wmf8)
Assigned To: Sucheta Ghoshal
:
Depends on:
Blocks: ve-linkediting
  Show dependency treegraph
 
Reported: 2013-07-11 22:09 UTC by Elitre
Modified: 2014-11-19 21:50 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Elitre 2013-07-11 22:09:17 UTC
A few users at itwp requested that the list of articles you can choose as a wikilink target supports right-click on each title to view the page in another tab; and that disambiguation pages in the same list appear differently (maybe italicized as it currently happens in MediaWiki special pages?) Thanks!
Comment 1 Chris McKenna 2013-08-05 12:38:25 UTC
You can use right click or ctrl+click on the links once inserted into the page, but per Bug 48915 this currently leads to the wrong namespace for links other than those to and from the article namespace.
Comment 2 Chris McKenna 2013-09-09 12:03:51 UTC
Bug 50240 asks for disambiguation pages to be distinguished in the list, so I'm retitling this one to focus on being able to open the targets with ctrl+click/right click. A user at en.wp has requested this functionality as well.
Comment 3 Roan Kattouw 2014-11-03 22:37:33 UTC
Both this and bug 50646 should be fixed by making the link suggestions real links, i.e. real <a> tags whose hrefs point to the pages they're suggesting.

To do that, you'd need MWLinkTargetInputWidget to use a specialized subclass of MenuItemWidget; right now it creates plain MenuItemWidgets. Eventually that specialized subclass could be enriched to contain an image and a description etc., per the new designs for the link inspector. We could also use this new widget in MWTitleInputWidget.
Comment 4 Roan Kattouw 2014-11-05 22:28:13 UTC
(In reply to Roan Kattouw from comment #3)
> Both this and bug 50646
Forget about bug 50646, my mistake, that one was about links in a different context. Comment #3 is still valid for this bug though.
Comment 5 Gerrit Notification Bot 2014-11-06 01:24:58 UTC
Change 171488 had a related patch set uploaded by SuchetaG:
Matching pages from suggestions in link dialog now actually work as links

https://gerrit.wikimedia.org/r/171488
Comment 6 Gerrit Notification Bot 2014-11-06 21:49:10 UTC
Change 171488 merged by jenkins-bot:
Matching pages from suggestions in link dialog now actually work as links

https://gerrit.wikimedia.org/r/171488
Comment 7 etonkovidova 2014-11-07 22:31:25 UTC
The fix is verified in betalabs(beware of a difference between Link and Simple link!). The fix applies to the Link.
Comment 8 etonkovidova 2014-11-19 21:50:06 UTC
Verified the fix in test2 and production.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links