Last modified: 2014-01-05 22:52:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T50915, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 48915 - VisualEditor: Respect Parsoid's <base>
VisualEditor: Respect Parsoid's <base>
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: High major
: VE-deploy-2013-10-31
Assigned To: Roan Kattouw
:
: 50216 50466 50764 51122 51585 53190 53491 (view as bug list)
Depends on:
Blocks: 51487
  Show dependency treegraph
 
Reported: 2013-05-28 22:19 UTC by James Forrester
Modified: 2014-01-05 22:52 UTC (History)
16 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description James Forrester 2013-05-28 22:19:48 UTC
Currently we don't -> lots of broken imagery in /w/index.php etc. entry points.
Comment 1 Roan Kattouw 2013-05-28 22:26:44 UTC
Timo says we can get the browser to do the resolution by getting the .href and .src properties in the original Parsoid document, so all we need to do is figure out which attributes are affected. I can think of href and src, are there others?
Comment 2 James Forrester 2013-06-26 18:07:54 UTC
*** Bug 50216 has been marked as a duplicate of this bug. ***
Comment 3 James Forrester 2013-07-05 00:42:51 UTC
*** Bug 50764 has been marked as a duplicate of this bug. ***
Comment 4 Bartosz Dziewoński 2013-08-05 12:29:02 UTC
*** Bug 51585 has been marked as a duplicate of this bug. ***
Comment 5 Bartosz Dziewoński 2013-08-05 12:29:14 UTC
*** Bug 51122 has been marked as a duplicate of this bug. ***
Comment 6 Bartosz Dziewoński 2013-08-05 12:30:17 UTC
Come on guys, this is "high major" since May.
Comment 7 Chris McKenna 2013-08-05 12:35:05 UTC
To hopefully help people find this bug, here is the description from bug 51122 "link targets assumed to be same namespace when opened with ctrl+click" updated to reflect that it now happens with all links, not just those in image captions:

When opening a link from the editing interface using ctrl+click (or "open in a new tab" from the right button menu) the link target is assumed to be in the same namespace as the currently edited page.

For example a link to [[Bridgnorth Cliff Railway]] from the page [[User:Thryduulf/sandbox]] is opened as [[User:Thryduulf/Bridgnorth Cliff Railway]]. A link to [[User:Thryduulf/sandbox2]] on the same page opens [[User:Thryduulf/User%3AThryduulf%2Fsandbox2]]. A link to that sandbox page
from a page in the article namespace opens as [[User%3AThryduulf%2Fsandbox2]], but this does get you to the correct page.
Comment 8 Elitre 2013-08-06 20:12:11 UTC
Also reported today at it.wp (this was the result https://it.wikipedia.org/w/Tsonga_%28popolazione%29 ). Thanks.
Comment 9 Chris McKenna 2013-08-25 15:39:52 UTC
*** Bug 50466 has been marked as a duplicate of this bug. ***
Comment 10 Chris McKenna 2013-08-28 19:39:59 UTC
*** Bug 53491 has been marked as a duplicate of this bug. ***
Comment 11 Bartosz Dziewoński 2013-08-28 22:04:27 UTC
Fun fact: this is the most often duped VE bug ever, and it's in the top 30 of most often duped open bugs on our entire bugzilla, alongside classics such as bug 738 or bug 156. https://bugzilla.wikimedia.org/duplicates.cgi
Comment 12 Bartosz Dziewoński 2013-08-28 22:05:33 UTC
*** Bug 53190 has been marked as a duplicate of this bug. ***
Comment 13 Gerrit Notification Bot 2013-09-26 02:14:31 UTC
Change 86065 had a related patch set uploaded by Catrope:
Resolve rendered URLs according to the provided <base>

https://gerrit.wikimedia.org/r/86065
Comment 14 Roan Kattouw 2013-09-27 00:23:53 UTC
(In reply to comment #13)
> Change 86065 had a related patch set uploaded by Catrope:
> Resolve rendered URLs according to the provided <base>
> 
> https://gerrit.wikimedia.org/r/86065
This addresses the most common symptoms of this bug. It fixes rendering of link targets for internal links (at least on initial rendering; the href attribute doesn't update correctly when the link is edited), and it fixes href and src attributes of things inside of generated content nodes (templates, mostly).

While the change in Gerrit fixes href/src attribute rendering for uneditable href/src attributes, we still have to do something for models that manage their own href/src and edit it, or generate it from another editable attribute.

ve.dm.LinkAnnotation, ve.dm.MWExternalLinkAnnotation: href attribute is edited directly; in practice MWExternalLinkAnnotation is a full URL and LinkAnnotation isn't used in the MW integration, but we should still fix them.

ve.dm.MWInternalLinkAnnotation: Generates href based on title attribute, which can be edited. Links that came directly from Parsoid now render correctly due to a hack (see bug 51487), but edited links don't render correctly.

ve.dm.ImageNode, ve.dm.MWInlineImageNode, ve.dm.MWBlockImageNode: src attribute is edited directly; in practice, the MW ones use full URLs (the user doesn't edit the src directly, and the UI widget gets full URLs from the API) and ImageNode isn't used in the MW integration, but we should still fix them.

ve.dm.MWCategoryMetaItem, ve.dm.MWLanguageMetaItem: these manage hrefs that can be edited, but they're never rendered and always absolute, so we don't really care
Comment 15 Gerrit Notification Bot 2013-10-21 19:23:45 UTC
Change 90952 had a related patch set uploaded by Catrope:
Render resolved URLs for href and src attributes in CE

https://gerrit.wikimedia.org/r/90952
Comment 16 Gerrit Notification Bot 2013-10-28 18:32:56 UTC
Change 86065 merged by jenkins-bot:
Resolve rendered URLs according to the provided <base>

https://gerrit.wikimedia.org/r/86065
Comment 17 Gerrit Notification Bot 2013-10-28 18:55:17 UTC
Change 90952 merged by jenkins-bot:
Render resolved URLs for href and src attributes in CE

https://gerrit.wikimedia.org/r/90952

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links