Last modified: 2014-02-08 00:41:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52240, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50240 - VisualEditor: Have the link inspector inform users if they're linking to a disambiguation or redirect page, or reinserting the same link
VisualEditor: Have the link inspector inform users if they're linking to a di...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Normal enhancement
: VE-deploy-2014-02-13
Assigned To: Alex Monk
:
: 50986 51524 (view as bug list)
Depends on:
Blocks: ve-linkediting
  Show dependency treegraph
 
Reported: 2013-06-26 16:09 UTC by Oliver Keyes
Modified: 2014-02-08 00:41 UTC (History)
13 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Oliver Keyes 2013-06-26 16:09:04 UTC
Totally a nice-to-have; it'd be good if the link inspector could inform users that they're linking through to a DAB page.
Comment 1 Nicolas Raoul 2013-06-27 08:50:18 UTC
I agree for disambiguation pages.

But I believe creating a wikilink to a redirect page is OK. For instance linking to "HTC Super3" even though it is actually a redirect to "HTC Super".
Comment 2 Oliver Keyes 2013-06-27 11:34:35 UTC
Sure; I don't think we're saying it shouldn't /let/ the user, merely that it should inform the user.
Comment 3 James Forrester 2013-07-10 16:13:42 UTC
*** Bug 50986 has been marked as a duplicate of this bug. ***
Comment 4 Ryan Kaldari 2013-07-15 20:54:40 UTC
This has been implemented in the old editor (WikiEditor). See https://gerrit.wikimedia.org/r/#/c/70564/ for the implementation details. It should be easy to add this feature to VisualEditor as well.
Comment 5 Patrick Earley 2013-07-15 23:42:02 UTC
This has come up in a discussion about surging numbers of dablinks being noticed by the dab project.  If VE is the source for this uptick, we should think about getting this fix in sooner rather than later. 

Discussion on en.:
http://en.wikipedia.org/wiki/Wikipedia:Village_pump_%28miscellaneous%29#Disambiguation_in_crisis
Comment 6 Ryan Kaldari 2013-07-16 21:43:22 UTC
The current code related to this functionality is in VisualEditor/modules/ve-mw/ui/widgets/ve.ui.MWLinkTargetInputWidget.js if anyone wants to take a shot at it.
Comment 7 John Mark Vandenberg 2013-07-22 10:17:58 UTC
*** Bug 51524 has been marked as a duplicate of this bug. ***
Comment 8 Saehrimnir 2013-07-25 14:32:13 UTC
Hi is anyone working on this since it is now deployed on more wikipedias this will become a bigger and bigger problem? Before VE people were checking if the Link was going to the right target more often because it was possible to have typos but with a drop down list they are bound to rely that what they pick will work as intended.
Comment 9 Elitre 2013-08-01 15:12:35 UTC
Can we also ask that VE warns about "auto-links", which is, links in the article pointing to the article itself? https://bugzilla.wikimedia.org/show_bug.cgi?id=50497 explains why those links can happen, but that is true for templates, I can't recall real reasons for wanting that to happen in the article body as well.
So [[user:Fram]] suggested that a warning would be useful in that case.
Comment 10 Raimond Spekking 2013-12-22 14:48:10 UTC
Hint: Links to disambig pages can now be easily checked with the isDisambiguationPage() function introduced with Gerrit change #100413.
Comment 11 Gerrit Notification Bot 2014-01-31 23:13:32 UTC
Change 110654 had a related patch set uploaded by Alex Monk:
Mark disambiguation and redirect pages in the link inspector

https://gerrit.wikimedia.org/r/110654
Comment 12 Gerrit Notification Bot 2014-02-08 00:09:28 UTC
Change 110654 merged by jenkins-bot:
Mark disambiguation and redirect pages in the link inspector

https://gerrit.wikimedia.org/r/110654

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links