Last modified: 2013-11-11 15:44:12 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52872, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50872 - VisualEditor: Pre-fill the section title in the edit summary when launched from a section edit link
VisualEditor: Pre-fill the section title in the edit summary when launched fr...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: Normal enhancement
: VE-deploy-2013-07-25
Assigned To: Ed Sanders
:
: 50535 51343 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-06 22:37 UTC by Chris McKenna
Modified: 2013-11-11 15:44 UTC (History)
12 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Chris McKenna 2013-07-06 22:37:02 UTC
Even though section editing in VE is a long way off, it would be really helpful if the title of the section you click edit on was automatically included in the edit summary in the same way that the source editor does. For example, when making [https://en.wikipedia.org/w/index.php?title=Viareggio_train_derailment&diff=next&oldid=563164136 this edit] I launched the VE by clicking on the edit link for the "See also" section, so I was expecting the edit summary to begin with the usual "-> See also". This provides context for the edit summary and so helps give context at recent changes and on watchlists.
Comment 1 James Forrester 2013-07-06 23:58:10 UTC
(In reply to comment #0)
> Even though section editing in VE is a long way off, it would be really
> helpful if the title of the section you click edit on was automatically
> included in the edit summary in the same way that the source editor does.
> For example, when making https://en.wikipedia.org/w/?diff=next&oldid=563164136
> this edit I launched the VE by clicking on the edit link for the "See also"
> section, so I was expecting the edit summary to begin with the usual "-> See
> also". This provides context for the edit summary and so helps give context
> at recent changes and on watchlists.

Won't this be rather mis-leading? Normally reviewers will expect the changes to be limited to that section, whereas editors are unlikely to keep their changes restricted in that way. Potentially we could add it into the edit summary box before the user adds anything, so they can remove it if they want?
Comment 2 James Forrester 2013-07-07 00:00:12 UTC
*** Bug 50535 has been marked as a duplicate of this bug. ***
Comment 3 Chris McKenna 2013-07-07 07:44:52 UTC
Absolutely it can (and probably should) be removable.

As for editing other sections, hmm. My initial thought is to wonder whether it could be detectable from the diff generator which section(s) have been edited?
Comment 4 David Gerard 2013-07-07 08:27:36 UTC
Well, having a misleading "edit section" link isn't considered a problem.
Comment 5 James Forrester 2013-07-15 23:51:19 UTC
*** Bug 51343 has been marked as a duplicate of this bug. ***
Comment 6 Gerrit Notification Bot 2013-07-18 22:38:44 UTC
Change 74545 had a related patch set uploaded by Esanders:
Prepend section title to edit summary

https://gerrit.wikimedia.org/r/74545
Comment 7 Roan Kattouw 2013-07-23 18:51:34 UTC
*** Bug 51903 has been marked as a duplicate of this bug. ***
Comment 8 kipod 2013-07-23 19:07:04 UTC
(In reply to comment #7)
> *** Bug 51903 has been marked as a duplicate of this bug. ***

not exactly: this bug is about "when launched from section edit link".

IMO, this will be wrong: VE does not support section edit, and a user can launch VE from a section edit link, and then do whatever anywhere on the page. 

bug 51903 asked VE to analyze the page when the user press "save", find out whether or not the changes are confined to a specific section, and if so (regardless of how VE was launched), add the section name to the summary.

so i do not think these two are truly "duplicates". 
if anything, this bug should be marked "invalid" and bug 51903 should be resurrected (51903 was opened as "enhancement request").

peace.
Comment 9 Gerrit Notification Bot 2013-07-23 23:02:17 UTC
Change 74545 merged by jenkins-bot:
Prepend section title to edit summary

https://gerrit.wikimedia.org/r/74545
Comment 10 James Forrester 2013-07-24 02:54:38 UTC
Done and will be deployed tomorrow.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links