Last modified: 2013-07-22 15:56:36 UTC
Created attachment 12712 [details] A very simple mockup that I made in GIMP to show how it is supposed to look VisualEditor: Link inspector is not oriented for RTL. The arrow icon is supposed to point to the right, and be placed in the right corner, separated by a vertical line. The title is supposed to be aligned to the right. The chain icon is supposed to be next to the title on its left side. The trash bin is supposed to be in the left corner. See the attached file for a very simple mock-up of how it is supposed to look (it is off by a few pixels here and there - I'm not much of a graphic designer). This bug is similar to bug 49613.
Created attachment 12713 [details] A simple mockup that I made in GIMP to show how it is supposed to look The V icon in the menu is supposed to be moved to the right side, too. Updated screenshot.
This depends on the Frame rtl fix, which will add directionality inside frames, and allow for conditional flips (and/or also allow CSSJanus to eventually work inside the frames) I took a look at the code, the flip itself is relatively easy, but I am missing the ve-rtl/ve-ltr classes that would be there after the frame fix.
Change 72056 had a related patch set uploaded by Mooeypoo: Layout fix for Link Surface in RTL https://gerrit.wikimedia.org/r/72056
Change 72056 abandoned by Mooeypoo: Layout fix for Link Surface in RTL Reason: This was fixed in another (much more massive) gerrit fix that was merged. Works in master. https://gerrit.wikimedia.org/r/72056
En layout is currently: < (chain icon) 'Hyperlink' (trash icon) He layout is currently: (trash icon) '(Hyperlink in Hebrew)' (chain icon) > This is not quite Amir's design attached: (trash icon) (chain icon) '(Hyperlink in Hebrew)' >
The current layout is good. There's a mistake in my image. Marking as FIXED.
