Last modified: 2014-01-03 15:44:56 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51546, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 49546 - VisualEditor: CSS broken in RTL
VisualEditor: CSS broken in RTL
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: High major
: VE-deploy-2013-07-18
Assigned To: Moriel Schottlender
:
Depends on: 50490
Blocks: ve-rtl
  Show dependency treegraph
 
Reported: 2013-06-13 20:28 UTC by James Forrester
Modified: 2014-01-03 15:44 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description James Forrester 2013-06-13 20:28:07 UTC
We have plans to use ResourceLoader which will fix a lot of this, but noting it here.

Most obviously, the toolbar has two sections which in LRT appear as ABCDE  1234; in RTL they should be 4321  EDCBA, but instead appear as EDCBA  4321. Also issues in dialogs etc.
Comment 1 Moriel Schottlender 2013-06-18 17:09:07 UTC
I went through the Link Inspector CSS issue and it gave me an insight into what may be happening here. 

Using CSSJanus will probably help 90% of this problem, but it might not completely solve it. A lot of the position settings are inline, calculated dynamically and inserted into the element itself. I'm not entirely sure CSSJanus knows how to deal with those. We may have to split the calculation up into RTL and LTR positions, or find some other solution to the popups that are calculated dynamically.
Comment 2 Moriel Schottlender 2013-07-23 15:10:11 UTC
This is fixed in general by the introduction of Roan and Trevor's css-frame fixes, and the popup menu fixes (in TextMenuWidget) - and I think that the rest would likely result in spot-fixes, like the ones with the transclusion editor.

Also, as far as I could see, the toolbar bug was fixed as well.

I think we can close this bug and rely on the main BIDI/RTL tracking bug to continue work on any individual bugs as they happen.
Comment 3 James Forrester 2013-07-23 15:16:03 UTC
(In reply to comment #2)
> This is fixed in general by the introduction of Roan and Trevor's css-frame
> fixes, and the popup menu fixes (in TextMenuWidget) - and I think that the
> rest would likely result in spot-fixes, like the ones with the transclusion
> editor.
> 
> Also, as far as I could see, the toolbar bug was fixed as well.
> 
> I think we can close this bug and rely on the main BIDI/RTL tracking bug to
> continue work on any individual bugs as they happen.

OK, done.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links