Last modified: 2013-07-08 21:24:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51613, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 49613 - Page settings dialog is not oriented for RTL
Page settings dialog is not oriented for RTL
Status: VERIFIED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2013-07-11
Assigned To: Moriel Schottlender
:
Depends on:
Blocks: ve-rtl
  Show dependency treegraph
 
Reported: 2013-06-15 07:55 UTC by Amir E. Aharoni
Modified: 2013-07-08 21:24 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
screenshot of more problems. issues are marked in red. (16.85 KB, image/png)
2013-07-05 09:26 UTC, Amir E. Aharoni
Details

Description Amir E. Aharoni 2013-06-15 07:55:34 UTC
The Page settings dialog is not oriented for RTL. The sidebar must be on the right-hand side, the title is supposed to be on the right, the closing X is supposed to be on the left, the Apply settings button is supposed to be on the left, etc.
Comment 1 James Forrester 2013-06-16 22:16:03 UTC
Is this "just" an artefact of us not using CSSJanus? See bug 49546.
Comment 2 Gerrit Notification Bot 2013-06-18 18:59:07 UTC
Related URL: https://gerrit.wikimedia.org/r/69341 (Gerrit Change I418e669b0999552167683352acb365a4249ab9cc)
Comment 3 Gerrit Notification Bot 2013-07-02 20:22:36 UTC
Change 69341 merged by jenkins-bot:
Dir fix for iframes and widgets

https://gerrit.wikimedia.org/r/69341
Comment 4 Moriel Schottlender 2013-07-05 01:25:45 UTC
Solved. Can be marked as resolved.
Comment 5 Amir E. Aharoni 2013-07-05 09:26:49 UTC
Created attachment 12758 [details]
screenshot of more problems. issues are marked in red.

It's much better now, thanks!

I found a couple of other small issues:

1. The icons is the sidebar menu are supposed to be on the right-hand side.

2. The table headers in the languages menu seem to be aligned to the left. The should be aligned to the right.
Comment 6 Gerrit Notification Bot 2013-07-05 17:45:26 UTC
Change 72115 had a related patch set uploaded by Mooeypoo:
Page settings fix-fix

https://gerrit.wikimedia.org/r/72115
Comment 7 Gerrit Notification Bot 2013-07-05 18:09:39 UTC
Change 72115 merged by jenkins-bot:
Page settings fix-fix

https://gerrit.wikimedia.org/r/72115
Comment 8 James Forrester 2013-07-05 18:12:02 UTC
Really fixed this time, I think.
Comment 9 Amir E. Aharoni 2013-07-07 09:52:31 UTC
Verified on my test wiki. Thanks!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links