Last modified: 2013-10-28 18:55:14 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53487, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 51487 - VisualEditor: Get rid of dmRendering stuff in ce.MWInternalLinkAnnotation
VisualEditor: Get rid of dmRendering stuff in ce.MWInternalLinkAnnotation
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Technical Debt (Other open bugs)
unspecified
All All
: Low normal
: VE-deploy-2013-10-31
Assigned To: Roan Kattouw
:
Depends on: 48915
Blocks:
  Show dependency tree / graph
 
Reported: 2013-07-16 22:45 UTC by Roan Kattouw
Modified: 2013-10-28 18:55 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Roan Kattouw 2013-07-16 22:45:09 UTC 
Right now, ce.MWInternalLinkAnnotation obtains a DM rendering to get the computed href. We should factor out href computation so that this isn't needed.
Comment 1 Gerrit Notification Bot 2013-09-26 02:14:26 UTC 
Change 86065 had a related patch set uploaded by Catrope:
Resolve rendered URLs according to the provided <base>

https://gerrit.wikimedia.org/r/86065
Comment 2 Roan Kattouw 2013-09-27 00:05:03 UTC 
(In reply to comment #1)
> Change 86065 had a related patch set uploaded by Catrope:
> Resolve rendered URLs according to the provided <base>
> 
> https://gerrit.wikimedia.org/r/86065
This change tried to just get rid of href computation, but that's not good enough. It does need to actually be computed.
Comment 3 Roan Kattouw 2013-09-27 00:16:48 UTC 
(In reply to comment #2)
> (In reply to comment #1)
> > Change 86065 had a related patch set uploaded by Catrope:
> > Resolve rendered URLs according to the provided <base>
> > 
> > https://gerrit.wikimedia.org/r/86065
> This change tried to just get rid of href computation, but that's not good
> enough. It does need to actually be computed.

The most recent version of this change actually makes the hack worse, in order to partly fix bug 48915. Once that bug is fixed properly, this hack can be removed.
Comment 4 Gerrit Notification Bot 2013-10-21 19:23:52 UTC 
Change 90953 had a related patch set uploaded by Catrope:
Get rid of dmRendering hack in ve.ce.MWInternalLinkAnnotation

https://gerrit.wikimedia.org/r/90953
Comment 5 Gerrit Notification Bot 2013-10-28 18:55:14 UTC 
Change 90953 merged by jenkins-bot:
Get rid of dmRendering hack in ve.ce.MWInternalLinkAnnotation

https://gerrit.wikimedia.org/r/90953
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links