Last modified: 2014-04-08 18:14:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T49506, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 47506 - Toolbar icons overlap edit box in IE8
Toolbar icons overlap edit box in IE8
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikiEditor (Other open bugs)
master
All All
: High normal with 5 votes (vote)
: ---
Assigned To: Derk-Jan Hartman
:
: 26982 49609 49836 (view as bug list)
Depends on: 25378
Blocks:
  Show dependency treegraph
 
Reported: 2013-04-22 13:33 UTC by Thorsten
Modified: 2014-04-08 18:14 UTC (History)
16 users (show)

See Also:
Web browser: Internet Explorer
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Thorsten 2013-04-22 13:33:32 UTC
Some toolbar icons overlap edit box in Internet Explorer 8, see screenshot [1]. This was reported in dewiki [2] and I can reproduce this.


[1] http://de.wikipedia.org/wiki/Datei:Leiste_Artikel_Bearbeiten_defekt.jpg

[2] http://de.wikipedia.org/w/index.php?title=Wikipedia:Fragen_zur_Wikipedia&diff=prev&oldid=117578111#Zerschossene_Leiste_beim_Artikel_bearbeiten
Comment 1 Thorsten 2013-04-22 13:37:42 UTC
Might be related to Bug 27698.
Comment 2 Filzstift 2013-04-25 13:07:32 UTC
I can confirm the issue with Internet Explorer 8 in Windows 7.
Comment 3 Andre Klapper 2013-06-13 14:24:26 UTC
Filzstift, Thorsten: Is this still a problem?
Comment 4 Thorsten 2013-06-14 06:09:51 UTC
Unchanged with IE 8.0 on Win XP.
Comment 5 Filzstift 2013-06-14 07:37:27 UTC
I don't have anymore an IE 8 environment so I cannot test it again.
Comment 6 Michael M. 2013-06-14 09:01:33 UTC
I can reproduce with IE9 in compatibility mode on Windows 7.

Just open the advanced bar. In the groups with labels (format and insert), the icons will show below the label and overlap the textbox.
Comment 7 Andre Klapper 2013-06-16 21:02:37 UTC
Also see screenshots in bug 49609
Comment 8 Andre Klapper 2013-06-16 21:03:04 UTC
*** Bug 49609 has been marked as a duplicate of this bug. ***
Comment 9 Andre Klapper 2013-06-19 23:28:13 UTC
*** Bug 49836 has been marked as a duplicate of this bug. ***
Comment 10 Andre Klapper 2013-08-29 12:01:46 UTC
*** Bug 53442 has been marked as a duplicate of this bug. ***
Comment 11 Gavin Munro 2013-10-03 13:16:01 UTC
This bug also occurs in Chrome
Comment 12 Andre Klapper 2013-10-03 14:36:22 UTC
(In reply to comment #11)
> This bug also occurs in Chrome

Version information plus wiki URL to reproduce welcome.
Comment 13 Gavin Munro 2013-10-03 23:18:13 UTC
Comment 11 is an error. It applies to bug 54919.
Comment 14 gerd.huhn 2013-10-16 12:40:32 UTC
Bug still there MW 1.21.2 and latest WikiEditor Snapshot and IE8 ... is there no fast solution? maybe it is possible to add a new line to the advanced menu and display the area always with a bigger hight?!? not nice but always better then overlapping in IE8 ...
Comment 15 wikimedia 2013-12-04 00:02:18 UTC
If you are hosting MediaWiki as an Intranet site, IE will always force sites in the 'Intranet Zone' to compatibility mode.

To tell IE not to treat MediaWiki in compat mode, you need to add either the <meta http-equiv="X-UA-Compatible" content="IE=10" /> tag to the HTML content, or the "X-UA-Compatible: IE=10" HTTP header.

If you are hosting on IIS, you can modify your web.config file to add the custom HTTP header like so:

<system.webServer>
  <configuration>
    <httpProtocol>
      <customHeaders>
        <clear />
        <add name="X-UA-Compatible" value="IE=10" />
      </customHeaders>
    </httpProtocol>
  </system.webServer>
</configuration>
Comment 16 Chris Koerner 2014-01-08 16:03:32 UTC
This issue is still present with MediaWiki 1.23wmf8 and WikiEditor 0.3.1 (b46c796). Changing compatibility mode does not alter the behavior. Applies to both wikipedia.org and an internal wiki I administer.

It appears to be a CSS issue, but I can't determine the attribute to modify.
Comment 17 Bartosz Dziewoński 2014-01-14 21:39:59 UTC
Someone should retriage this with the parent bug 25378 now fixed.
Comment 18 Thorsten 2014-01-15 07:07:22 UTC
Nothing changed.
Comment 19 Chris Koerner 2014-01-16 18:51:10 UTC
(In reply to comment #18)
> Nothing changed.

Confirmed. WikiEditor master still presents this issue in IE 8. Compatibility mode does not effect results of testing. Appears on Wikipedia.org and internal wiki.
Comment 20 Chris Koerner 2014-01-24 20:58:44 UTC
A work around (and possible hint as to what is causing the issue) is to remove the labels fro the Format and Insert groups.

in \w\extensions\WikiEditor\WikiEditor.i18n.php modify the following entries (removing the Format and Insert labels):
'wikieditor-toolbar-group-format' => '',
'wikieditor-toolbar-group-insert' => '',
Comment 21 Dan Barrett 2014-02-13 18:14:46 UTC
Even with Chris Koerner's workaround (Comment 20), IE8 still throws the following error when I click on "Special characters":

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.1; WOW64; Trident/4.0; SLCC2; .NET CLR 2.0.50727; InfoPath.2; .NET CLR 3.5.30729; .NET CLR 3.0.30729; .NET4.0C; .NET4.0E)
Timestamp: Thu, 13 Feb 2014 18:13:22 UTC

Message: 'console' is undefined
Line: 566
Char: 3
Code: 0
URI: http://danbwiki.vistaprint.net/w/extensions/WikiEditor/modules/jquery.wikiEditor.toolbar.js
Comment 22 Dan Barrett 2014-02-13 18:16:12 UTC
The offending line in the above comment seems to be:

console.log( "A character for the toolbar was undefined. This is not supposed to happen. Double check the config." );
Comment 23 Derk-Jan Hartman 2014-04-07 15:04:17 UTC
This console error you are seeing was fixed by now in master it seems. just FYI
Comment 24 Gerrit Notification Bot 2014-04-07 15:32:56 UTC
Change 124335 had a related patch set uploaded by TheDJ:
Fix broken span of label in WikiEditor toolbar

https://gerrit.wikimedia.org/r/124335
Comment 25 Derk-Jan Hartman 2014-04-07 15:34:10 UTC
I'm not 100% positive the above patch fixes it, but it does sound like a very logical candidate.
Comment 26 Gerrit Notification Bot 2014-04-07 22:08:04 UTC
Change 124335 merged by jenkins-bot:
Fix broken span of label in WikiEditor toolbar

https://gerrit.wikimedia.org/r/124335
Comment 27 Derk-Jan Hartman 2014-04-08 00:20:44 UTC
*** Bug 26982 has been marked as a duplicate of this bug. ***
Comment 28 Bartosz Dziewoński 2014-04-08 10:34:23 UTC
Could somebody verify that the patch fixed the issue? It's not yet deployed on Wikipedias, but I deployed it on my testing wiki: http://users.v-lo.krakow.pl/~matmarex/testwiki/ (use user: testwiki, password: testwiki to access the site, it's a crude antispam measure). Feel free to create accounts and edit articles and do whatever you think necessary. :)
Comment 29 Derk-Jan Hartman 2014-04-08 11:21:13 UTC
I checked on a PC I have occasional access to and this does indeed fix the problem.
Comment 30 Thorsten 2014-04-08 14:22:42 UTC
Confirm. Looks good for me on your testing wiki.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links