Last modified: 2012-11-29 12:37:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T39496, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 37496 - Display a diff between two revisions of a Wikidata item
Display a diff between two revisions of a Wikidata item
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Daniel Kinzler
:
Depends on: 37680 37747
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-12 11:19 UTC by denny vrandecic
Modified: 2012-11-29 12:37 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description denny vrandecic 2012-06-12 11:19:19 UTC
When two revisions of a Wikidata item are selected, a diff should be created and displayed.
Comment 1 Daniel Kinzler 2012-06-18 15:14:52 UTC
Implementation is in gerrit for review: https://gerrit.wikimedia.org/r/11865

I have implemented this based on the normal wikitext diff, using the same side-by-side layout and recycling the CSS. As a context (instead of the line number), the path to the changed value is shown, using the keys from our internal JSON representation. That sucks, of course.

This implementation doesn't work correctly at the moment, because it depends on some other things to be fixed, most importantly bug 37680, but also bug 37691 and bug 37683.

Anyway, some actual UI design seems in Order here. Some thoughts:

* side-by-side seems useless.
* instead, show added, removed and modified properties in a single column
* for modified properties, show a word-based diff
* it may be nice to just show the (old) item with highlighted modifications (inline diff)
* diffs will often be for a single atomic change. It could be useful to make this a special case.
Comment 2 Daniel Kinzler 2012-06-19 13:43:32 UTC
https://gerrit.wikimedia.org/r/11865 was merged
Comment 3 Daniel Kinzler 2012-06-21 10:36:14 UTC
revision headers still need to be fixed
Comment 4 Daniel Kinzler 2012-06-26 09:23:02 UTC
fixed now, though design/UX issues remain.
Comment 5 denny vrandecic 2012-06-26 09:41:45 UTC
Added item #37958 for improving the design/UX issues.
Comment 6 Anja Jentzsch 2012-11-29 12:37:49 UTC
Verified in Wikidata demo time for sprint 7

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links