Last modified: 2012-11-29 13:07:11 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T39691, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 37691 - ItemView should honor ParserOptions::getEditSection() to suppress edit functionality.
ItemView should honor ParserOptions::getEditSection() to suppress edit functi...
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
master
All All
: High normal (vote)
: ---
Assigned To: Daniel Kinzler
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-06-18 14:25 UTC by Daniel Kinzler
Modified: 2012-11-29 13:07 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Daniel Kinzler 2012-06-18 14:25:49 UTC 
Inline editing does not make sense in all places where an item is shown. E.g. when an item is shown as a preview or as context in a diff, editing should be disabled.

MediaWiki already makes this distinction for WikiText, where section edit links are suppressed in such situation. I think Wikibase should use the same hint to suppress inline editing.

It ParserOptions::getEditSection() can be used to determine whether inline editing should be enabled.
Comment 1 Daniel Kinzler 2012-06-25 12:14:18 UTC 
under review https://gerrit.wikimedia.org/r/#/c/12856/
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links