Last modified: 2012-11-29 13:07:37 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T39747, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 37747 - Adjust diff headers in Wikibase\DifferenceEngine
Adjust diff headers in Wikibase\DifferenceEngine
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
master
All All
: High normal (vote)
: ---
Assigned To: Daniel Kinzler
:
Depends on: 37683
Blocks: 37496
  Show dependency tree / graph
 
Reported: 2012-06-20 16:24 UTC by Daniel Kinzler
Modified: 2012-11-29 13:07 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Daniel Kinzler 2012-06-20 16:24:30 UTC 
Wikibase\DifferenceEngine currently shows the normal headers for the two revisions in the two columns of the side-by-side layout. This needs to be changed in order to replace the "edit" links with "reset" links, at the very leat.
Comment 1 Daniel Kinzler 2012-06-21 10:38:16 UTC 
block completion of diff feature
Comment 2 Daniel Kinzler 2012-06-25 12:10:33 UTC 
in review https://gerrit.wikimedia.org/r/#/c/12859/
Comment 3 Daniel Kinzler 2012-06-25 12:12:53 UTC 
oops, sorry, bad link. 

in review as https://gerrit.wikimedia.org/r/#/c/12858/
Comment 4 Daniel Kinzler 2012-06-26 09:03:43 UTC 
merged
Comment 5 denny vrandecic 2012-06-26 11:15:45 UTC 
Do I understand it correctly that we need an item to create an action "reset"? If yes, I will add it.
Comment 6 denny vrandecic 2012-06-26 11:17:12 UTC 
Also, the "undo" link is still there and doesn't seem to do anything useful?
Comment 7 Daniel Kinzler 2012-06-26 12:45:48 UTC 
yes, we need a ticket for "reset". it's similar to bug 37683, but not the same.

undo should in principle work, we just need to implement ContentHandler::merge3() for items.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links