Last modified: 2014-11-17 10:36:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T26430, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 24430 - Remove "cols" user preference from MediaWiki core
Remove "cols" user preference from MediaWiki core
Status: PATCH_TO_REVIEW
Product: MediaWiki
Classification: Unclassified
User preferences (Other open bugs)
1.17.x
All All
: Low minor with 2 votes (vote)
: Future release
Assigned To: Nobody - You can work on this!
: easy
: 26815 (view as bug list)
Depends on: 33780
Blocks: 52807
  Show dependency treegraph
 
Reported: 2010-07-18 11:01 UTC by Niklas Laxström
Modified: 2014-11-17 10:36 UTC (History)
14 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch to remove columns preference from user prefrences (4.05 KB, patch)
2011-09-30 22:03 UTC, Chinchin
Details
Removed cols preference (3.65 KB, patch)
2011-10-01 21:50 UTC, Chinchin
Details

Description Niklas Laxström 2010-07-18 11:01:07 UTC
Preferences always ask the number of colums for edit field, but only nostalgia and standard seem to use that preference. Either ask it only for those skins, or make those skins behave like the others.
Comment 1 Chad H. 2010-07-19 17:40:01 UTC
Good candidate for a preference to kill?
Comment 2 Lejonel 2011-02-06 19:15:10 UTC
*** Bug 26815 has been marked as a duplicate of this bug. ***
Comment 3 p858snake 2011-07-14 10:35:18 UTC
This got discussed somewhere else I think, didn't you end up removing this in trunk chad because it wasn't actually setup to be used anywhere?
Comment 4 Niklas Laxström 2011-07-14 11:29:03 UTC
It's still in trunk.
Comment 5 Daniel Friesen 2011-09-20 00:51:13 UTC
Exterminate! EXTERMINATE!
Comment 6 Chinchin 2011-09-30 22:03:21 UTC
Created attachment 9135 [details]
Patch to remove columns preference from user prefrences

Tested only with default skin. Applies on top of 1.17.
Comment 7 Daniel Friesen 2011-10-01 01:57:34 UTC
I'd love to just drop that preference, though in a bit of quick testing in older skins eliminating the col= leads to it being unusably narrow.

I think we'll need to accompany this along with moving width: 100%; from skin specific css to the globally applied shared.css. While we're at it we might as well apply box-sizing: border-box; as well.
Comment 8 Chinchin 2011-10-01 21:50:01 UTC
Created attachment 9137 [details]
Removed cols preference

Rebased against trunk
Comment 9 bsitu 2011-12-23 22:48:09 UTC
Applied patch in r107187, thanks for the patch
Comment 10 Dan Jacobson 2012-01-19 02:38:09 UTC
But you wiped out any reasonable default too, causing Bug 33780!
Comment 11 bsitu 2012-01-19 18:38:18 UTC
Thanks for the note, additional patch is applied in r109557
Comment 12 Dan Jacobson 2012-01-25 00:46:52 UTC
(In reply to comment #11)
Dear Sir,
In http://www.w3.org/wiki/HTML/Elements/textarea
does it not say
  * cols = valid non-negative integer
    specifies the expected maximum number of characters per line. by defult, it is 20.

So why do you insist on not setting it to something reasonable like you do for
  * rows = valid non-negative integer
    Specifies the number of lines to show. by defult, it is 2.

just because things work out on your browser doesn't mean it is that way for others!!
Comment 13 Dan Jacobson 2012-01-25 00:49:09 UTC
No, the magic of CSS should not be a requirement in this case.
Comment 14 Dan Jacobson 2012-01-25 00:54:40 UTC
Even in the HTML5 example at
http://www.w3.org/TR/html5/the-button-element.html#the-textarea-element
  <p>If you have any comments, please let us know (you may use either English or Hebrew for your comments):
  <textarea cols=80 name=comments dirname=comments.dir></textarea></p>
they don't manage to forget it!
Comment 15 Dan Jacobson 2012-01-25 00:57:53 UTC
Indeed, they never ever forget it (cols=80). It's on every example!

4 matches for "<textarea" in buffer: 4.10.8 The button element — HTML5 *w3m*
    826:<p>If you have any comments, please let us know: <textarea cols=80 name=comments></textarea></p>
    830:<p>If you have any short comments, please let us know: <textarea cols=80 name=comments maxlength=200></textarea></p>
    834:<p>If you have any comments, please let us know: <textarea cols=80 name=comments>You rock!</textarea></p>
    840:<textarea cols=80 name=comments dirname=comments.dir></textarea></p>
Comment 16 Krinkle 2012-01-25 01:07:02 UTC
I agree. Looks like WebKit has a default of 20 cols:

> var a = document.createElement('textarea');
> a.cols
< 20
Comment 17 Bergi 2012-01-25 18:57:07 UTC
(In reply to comment #13)
> No, the magic of CSS should not be a requirement in this case.

What do you mean with "magic of CSS"?

Wouldn't it be OK just to remove the setting, and set a fix size of col=80 in the skin.php?
Comment 18 Dan Jacobson 2012-01-26 00:01:29 UTC
(In reply to comment #17)
> What do you mean with "magic of CSS"?
OK, the help of, use of, CSS.

> Wouldn't it be OK just to remove the setting, and set a fix size of col=80 in
> the skin.php?
Sounds good!
Comment 19 Dan Jacobson 2012-01-26 00:02:28 UTC
cols=80 not col. And maybe cols="80" even better...
Comment 20 MZMcBride 2012-01-26 15:50:04 UTC
Code reverted in r110007, r110008, r110009, r110010.
Comment 21 Dan Jacobson 2012-01-28 02:05:38 UTC
Thanks. Takes care of Bug 33780, I'm happy.
Comment 22 MZMcBride 2012-09-29 00:12:48 UTC
(In reply to comment #1)
> Good candidate for a preference to kill?

https://www.mediawiki.org/wiki/Requests_for_comment/Core_user_preferences
Comment 23 Chad H. 2012-09-29 16:22:50 UTC
(In reply to comment #22)
> (In reply to comment #1)
> > Good candidate for a preference to kill?
> 
> https://www.mediawiki.org/wiki/Requests_for_comment/Core_user_preferences

Tried before, need to make sure there's no regressions if we do.
Comment 24 Niklas Laxström 2013-06-16 20:55:49 UTC
We managed to get rid of the legacy skins but not this preference yet?
Comment 25 Bartosz Dziewoński 2013-08-13 18:54:17 UTC
With I07895f76 merged no core skin actually uses this. Let's just set cols=80 and kill the pref.
Comment 26 Gerrit Notification Bot 2013-08-20 17:43:39 UTC
Change 80061 had a related patch set uploaded by Demon:
Remove cols and rows preferences

https://gerrit.wikimedia.org/r/80061
Comment 27 Gerrit Notification Bot 2013-10-11 18:21:55 UTC
Change 80061 abandoned by Chad:
Remove cols and rows preferences

https://gerrit.wikimedia.org/r/80061
Comment 28 Nemo 2013-12-16 06:33:26 UTC
Hmm "The body textarea on Page: pages editing was too big. The size defined in User preferences is now used". <http://lists.wikimedia.org/pipermail/wikisource-l/2013-December/001700.html>
Tpt, if it's about this preference you may want to use the default value directly I guess.
Comment 29 Tpt 2013-12-16 07:30:19 UTC
(In reply to comment #28)
> Tpt, if it's about this preference you may want to use the default value
> directly I guess.
ProofreadPage uses EditPage::showTextbox to build its textareas and so has no direct dependence on cols and rows system messages. Delete these messages won't break anything in the extension.
Comment 30 Gerrit Notification Bot 2013-12-16 20:17:39 UTC
Change 101994 had a related patch set uploaded by Bsitu:
curl_setopt doesn't seem to url-encode the text

https://gerrit.wikimedia.org/r/101994
Comment 31 bsitu 2013-12-16 20:18:48 UTC
oops, sorry  wrong bug reference

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links