Last modified: 2011-03-13 18:05:22 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 9945 - Automatically combine <ref>s containing the same text
Automatically combine <ref>s containing the same text
Product: MediaWiki extensions
Classification: Unclassified
Cite (Other open bugs)
All All
: Lowest enhancement with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
: 16222 (view as bug list)
Depends on:
  Show dependency treegraph
Reported: 2007-05-17 21:35 UTC by Peter Schlömer
Modified: 2011-03-13 18:05 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Patch against Cite.php (SVN r22012) (362 bytes, patch)
2007-05-17 21:35 UTC, Peter Schlömer

Description Peter Schlömer 2007-05-17 21:35:24 UTC
Created attachment 3647 [details]
Patch against Cite.php (SVN r22012)

I suggest changing the Cite extension to automatically combine <ref>s with the same text, just like those with the same name="..." parameter. It's not really necessary, but I think it doesn't hurt either. It's also just a minor change to the code, see the attached patch which uses the MD5 hash of the text instead of the name, when no name has been specified.
Comment 1 Aryeh Gregor (not reading bugmail, please e-mail directly) 2007-12-16 21:09:26 UTC
The patch makes the generated id much too long, and theoretically breaks links to existing id's (although they're fairly volatile, so probably there aren't many).  On that basis it's unacceptable.

I'm not sure if there's so much point in doing this, really, since a) even tiny changes like whitespace will break the merging, and b) people will change one reference and not another without realizing.  I foresee a lot of accidental duplication of references when people try to use this feature and get it slightly off.  Manual merging is probably a better method.
Comment 2 Chad H. 2008-11-03 14:57:42 UTC
*** Bug 16222 has been marked as a duplicate of this bug. ***
Comment 3 Bryan Baron 2009-09-23 20:31:26 UTC
The software shouldn't be making this kind of changes automatically. Several bot script can do this kind of task.

Note You need to log in before you can comment on or make changes to this bug.