Last modified: 2006-10-31 13:20:55 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T9764, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 7764 - missing explicit type casts. in DatabasePostgres.php


Summary:	missing explicit type casts. in DatabasePostgres.php

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	CategoryTree (Other open bugs)
Version:	unspecified
Hardware:	Other Linux

Importance:	Normal normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	postgres
	Show dependency tree / graph

Reported:	2006-10-30 21:13 UTC by Swen Wacker
Modified:	2006-10-31 13:20 UTC (History)
CC List:	1 user (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
A database error has occurred ... (2.21 KB, text/html) 2006-10-30 21:18 UTC, Swen Wacker	Details
Add an attachment (proposed patch, testcase, etc.)

Description Swen Wacker 2006-10-30 21:13:14 UTC

Using
MediaWiki: 1.8.2
PHP: 5.1.4-pl0-gentoo (apache)
PostgreSQL: PostgreSQL 8.1.4 on x86_64-pc-linux-gnu, compiled by GCC
x86_64-pc-linux-gnu-gcc (GCC) 3.4.5 (Gentoo 3.4.5, ssp-3.4.5-1.0, pie-8.7.9)

Used Extensions:
    * Special pages:
          o CategoryTree 
    * Parser hooks:
          o CategoryTree 
          o CharInsert
          o Inputbox
          o ParserFunctions

Opening Spezial:CategoryTree und looking for an (existing) Category says: 
Warning: pg_query() [function.pg-query]: Query failed: ERROR: function
if(boolean, integer, integer) does not exist HINT: No function matches the given
name and argument types. You may need to add explicit type casts. in
/var/(...)/mediawiki-1.8.2/includes/DatabasePostgres.php on line 381

Backtrace (using $wgShowExceptionDetails = true;) see attachment

Comment 1 Swen Wacker 2006-10-30 21:18:17 UTC

Created attachment 2603 [details]
A database error has occurred ...

Comment 2 Greg Sabino Mullane 2006-10-30 21:30:55 UTC

Looks like that extensions has some MySQLisms. Try this patch out to fix the
immediate problem:

Index: CategoryTreeFunctions.php
===================================================================
--- CategoryTreeFunctions.php   (revision 17312)
+++ CategoryTreeFunctions.php   (working copy)
@@ -180,7 +180,7 @@
                $categorylinks = $dbr->tableName( 'categorylinks' );

                $sql = "SELECT cat.page_namespace, cat.page_title,
-                                         if( cat.page_namespace = " .
NS_CATEGORY . ", 0, 1) as presort
+                               CASE WHEN cat.page_namespace=".NS_CATEGORY."
THEN 0 ELSE 1 END AS presort
                                          $transFields
                                FROM $page as cat
                                JOIN $categorylinks ON cl_from = cat.page_id

Comment 3 Swen Wacker 2006-10-30 21:47:03 UTC

Jepp! Thanks Greg, for this good and fast solution!

Comment 4 Greg Sabino Mullane 2006-10-31 13:20:55 UTC

Fixed in r17320.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links