Last modified: 2014-11-03 19:25:33 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T74681, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 72681 - copy JavaScript Title tests


Summary:	copy JavaScript Title tests

Status:	RESOLVED FIXED

Product:	Pywikibot
Classification:	Unclassified
Component:	tests (Other open bugs)
Version:	core-(2.0)
Hardware:	All All

Importance:	Unprioritized enhancement
Target Milestone:	---
Assigned To:	Fabian

URL:
Whiteboard:
Keywords:	easy

Depends on:
Blocks:	58941 pwb20
	Show dependency tree / graph

Reported:	2014-10-29 16:15 UTC by John Mark Vandenberg
Modified:	2014-11-03 19:25 UTC (History)
CC List:	1 user (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description John Mark Vandenberg 2014-10-29 16:15:41 UTC

We should have Link tests that are equivalent to these tests

https://git.wikimedia.org/blob/mediawiki%2Fcore.git/master/tests%2Fqunit%2Fsuites%2Fresources%2Fmediawiki%2Fmediawiki.Title.test.js

for this JS component:

https://git.wikimedia.org/blob/mediawiki%2Fcore.git/HEAD/resources%2Fsrc%2Fmediawiki%2Fmediawiki.Title.js

Comment 1 Fabian 2014-11-02 12:29:50 UTC

I'm working on adding those. Most of them already work but I want to fix most of them. You can see the progress for now in https://github.com/xzise/pywikibot-core/tree/official-link-tests (I'm uploading a review as soon as I think it should be merged).

Comment 2 Gerrit Notification Bot 2014-11-02 14:29:05 UTC

Change 170577 had a related patch set uploaded by XZise:
[FEAT] Advanced link tests

https://gerrit.wikimedia.org/r/170577

Comment 3 Gerrit Notification Bot 2014-11-02 15:20:45 UTC

Change 170577 merged by jenkins-bot:
[FEAT] Advanced link tests

https://gerrit.wikimedia.org/r/170577

Comment 4 Gerrit Notification Bot 2014-11-02 16:01:59 UTC

Change 170583 had a related patch set uploaded by XZise:
[FEAT] Advanced link tests

https://gerrit.wikimedia.org/r/170583

Comment 5 Gerrit Notification Bot 2014-11-03 17:08:10 UTC

Change 170583 merged by jenkins-bot:
[FEAT] Advanced link tests

https://gerrit.wikimedia.org/r/170583

Comment 6 Fabian 2014-11-03 19:25:33 UTC

Unless you see more tests we can convert from this I think this is now resolved.

Note You need to log in before you can comment on or make changes to this bug.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links