Last modified: 2014-10-14 13:43:53 UTC
Change 162153 had a related patch set uploaded by Prtksxna: inputs.less: Change focus state https://gerrit.wikimedia.org/r/162153
Created attachment 16538 [details] Disabled, Normal, and Focus states
There is a spec at https://trello.com/c/MC8ovuyw/2-advanced-input-fields . I guess the issue is that this may need to be updated because it's out of sync with what's implemented. Note that Prateek narrowed this to only cover text fields.
Created attachment 16539 [details] Disabled, Normal, and Focus states
There was a few issues with the previous focus state on text field. When the text field becomes activated, the blue bar hides the blinking cursor.
Shahyar, can you please take a look at the patchset?
(In reply to May from comment #5) > When the text field becomes activated, the blue bar hides the blinking > cursor. What browser does this happen in? I can see both in Firefox and Chromium. It's true the caret (blinking cursor) may not be quite as noticeable as it would be without the blue bar, but I'm not sure if this a problem. I confirmed with Prateek this is an enhancement bug to change the focus indicator, not a doc bug.
Created attachment 16541 [details] Current focus indicator in Firefox with caret showing
Created attachment 16758 [details] new password field Ehh, sorry, but i don't like the new indicator :/ I like the decent progressive bar at the left side, which identifies the focus to an text field. With this patch we become a border around the whole text field? I missed the patch for the buttons, and saw the new focus around the buttons on my dev-wiki and wasn't really enthusiastic. The main reason is, that it is too much of indication (look the screenshots). Just my opinion :) (P.S.: And i see no value of the new indicator?)
Created attachment 16759 [details] old password field (looks much better in my opinion)
(In reply to Florian in comment #9) > The main reason is, that it is too much of indication (look the screenshots) Having a border all around the element is also the default way some browsers show focus on buttons, inputs and links. There is no consistent API to style the outline they already provide which is why we have to implement it ourselves. Copying some points from the commit message of the patch - - Make focus state consistent across UI controls (analogous update for buttons is already merged and checkboxes coming soon). - Support for browsers that don't support box-shadow by making the border the same color.
(In reply to Prateek Saxena from comment #11) > There is no consistent API to > style the outline they already provide which is why we have to implement it > ourselves. That can be right, but doesn't change my opnion, that i more like the actual indicator (that's why i posted it here and not in gerrit, the change itself looks (technically) ok for me). Maybe there is a way to implement the actual indicator so, that it works in all browsers? :) (to be clear: i just want to say, that i like the actual (old) indicator much more, and this is, of couse, a personal opinion).
