Last modified: 2014-10-21 18:55:51 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T71724, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 69724 - Input blue indicators look strange when rounded corners are applied to mediawiki ui inputs
Input blue indicators look strange when rounded corners are applied to mediaw...
Status: RESOLVED WORKSFORME
Product: MediaWiki
Classification: Unclassified
MediaWiki UI (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on: 71150
Blocks:
  Show dependency treegraph
 
Reported: 2014-08-18 22:51 UTC by Maryana Pinchuk
Modified: 2014-10-21 18:55 UTC (History)
16 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Login form on mobile site on beta labs (viewed in desktop Chrome) (47.35 KB, image/png)
2014-08-18 22:51 UTC, Maryana Pinchuk
Details

Description Maryana Pinchuk 2014-08-18 22:51:02 UTC
Created attachment 16231 [details]
Login form on mobile site on beta labs (viewed in desktop Chrome)

On beta labs, the blue input indicator has begun to appear on the login & account creation form fields on the mobile site; however, since those fields have rounded corners on mobile and the input indicator evidently expects the square fields that are present on desktop, there's an awkward gap around the edges (see attached screenshot). There also appears to be some padding missing between the indicator and the input text, because it's quite close & crowded -- and imho the padding isn't entirely ideal on desktop, either :)
Comment 1 Jon 2014-08-19 00:04:38 UTC
I think the solution to this is to stop using a different login page for mobile.
Currently mobile rewrites the login page. We shouldn't have to do this any more.

The problem with the rendering is mobile styles input fields slightly different on this page e.g. rounded corners. We will need to change code in mobile or update the spec in core to change how this should render in mobile.
Comment 2 Bingle 2014-08-19 00:05:14 UTC
Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/nxvLBVNW
Comment 3 Gerrit Notification Bot 2014-08-19 00:39:20 UTC
Change 154979 had a related patch set uploaded by Jdlrobson:
Remove rounded corners on login form to get more login form consistency

https://gerrit.wikimedia.org/r/154979
Comment 4 Gerrit Notification Bot 2014-08-21 23:33:38 UTC
Change 154979 abandoned by Jdlrobson:
Remove rounded corners on login form to get more login form consistency

Reason:
Apparently this is not a big deal so abandoning.

https://gerrit.wikimedia.org/r/154979
Comment 5 Jared Zimmerman (WMF) 2014-10-08 22:40:40 UTC
I agree with Jon here.
Comment 6 Gerrit Notification Bot 2014-10-13 15:13:32 UTC
Change 165634 had a related patch set uploaded by Florianschmidtwelzow:
Use desktop login/account creation form in alpha

https://gerrit.wikimedia.org/r/165634
Comment 7 Prateek Saxena 2014-10-14 04:25:08 UTC
The new focus state designed by May should resolve this problem. There is a patch that introduces this change - I24f33a40cd0126ae95698c2a46858a15f502ca5b
Comment 8 Jon 2014-10-20 18:27:15 UTC
This actually looks fine now.
Comment 9 Gerrit Notification Bot 2014-10-21 18:55:51 UTC
Change 165634 merged by jenkins-bot:
Use desktop login/account creation form in alpha

https://gerrit.wikimedia.org/r/165634

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links