Last modified: 2014-11-08 06:57:21 UTC
Both compat and core wiktionary_family.py contains 'za' as live language, but this wiktionary is closed for two years
[[meta:Proposals_for_closing_projects/Closure_of_Zhuang_Wiktionary]], https://za.wiktionary.org/wiki/Yiebdaeuz
Change 161974 had a related patch set uploaded by Xqt: (bug 71115) Mark Zhuang wiktionary (za) as obsolete https://gerrit.wikimedia.org/r/161974
Change 161976 had a related patch set uploaded by Xqt: (bug 71115) Mark Zhuang wiktionary (za) as obsolete https://gerrit.wikimedia.org/r/161976
Change 161976 merged by jenkins-bot: (bug 71115) Mark Zhuang wiktionary (za) as obsolete https://gerrit.wikimedia.org/r/161976
Change 161974 merged by jenkins-bot: (bug 71115) Mark Zhuang wiktionary (za) as obsolete https://gerrit.wikimedia.org/r/161974
Lang code must been removed from self.languages_by_size too
Created attachment 16550 [details] patch
I'm getting a fatal "Language za in family wiktionary is obsolete" most of the time a page is getting saved, and it makes it impossible to use the bot. Probably it's because of what Jan is saying. Please correct ASAP.
Change 164774 had a related patch set uploaded by Mpaa: Bug 71115: Mark Zhuang wiktionary (za) as obsolete https://gerrit.wikimedia.org/r/164774
Change 164774 merged by jenkins-bot: Bug 71115: Mark Zhuang wiktionary (za) as obsolete https://gerrit.wikimedia.org/r/164774
Marked as fixed. Pls reopen if you see this again.
Still missing update for compat
Committed the changes to git but don't know what to do from here. Does it need somebody's approval?
(In reply to Malafaya from comment #13) > Committed the changes to git but don't know what to do from here. Does it > need somebody's approval? Next you need to upload them into Gerrit. http://mediawiki.org/wiki/Gerrit
Change 165229 had a related patch set uploaded by Malafaya: Bug 71115: Mark Zhuang wiktionary (za) as obsolete (compat) https://gerrit.wikimedia.org/r/165229
Change 165229 had a related patch set uploaded by Malafaya: Bug 71115: Mark Zhuang wiktionary (za) as obsolete https://gerrit.wikimedia.org/r/165229
Change 165229 merged by jenkins-bot: Bug 71115: Mark Zhuang wiktionary (za) as obsolete https://gerrit.wikimedia.org/r/165229
Fixed. Thanks, John Mark Vandenberg.
I'm reopening this because I'm just trying "core" per Mpaa's suggestion. I'm geting this error in core: D:\Work\py-core>pwb.py interwiki Categoria:Alemão -family:wiktionary -lang:pt Retrieving 1 pages from wiktionary:pt. ERROR: Traceback (most recent call last): File "D:\Work\py-core\pywikibot\data\api.py", line 586, in submit headers=headers, body=body) File "D:\Work\py-core\pywikibot\tools.py", line 559, in wrapper return obj(*__args, **__kw) File "D:\Work\py-core\pywikibot\comms\http.py", line 232, in request host = site.ssl_hostname() File "D:\Work\py-core\pywikibot\site.py", line 555, in <lambda> f = lambda *args, **kwargs: method(self.code, *args, **kwargs) File "D:\Work\py-core\pywikibot\family.py", line 995, in ssl_hostname return self.hostname(code) File "D:\Work\py-core\pywikibot\family.py", line 991, in hostname return self.langs[code] KeyError: u'za' 'za' Wiktionary has been marked obsolete some time ago. I manage to "pwb.py login" without any problem. ---- Pywikibot: [ssh] pywikibot-core.git (80350a2, g17, 2014/11/04, 10:19:53, ok) Release version: 2.0b2 httplib2 version: 0.9 cacerts: D:\Work\py-core\externals\httplib2\python2\httplib2\cacerts.txt certificate test: ok Python: 2.7.5 (default, May 15 2013, 22:44:16) [MSC v.1500 64 bit (AMD64)] unicode test: ok
fwiw, cant reproduce the bug now that it has been removed https://pt.wiktionary.org/w/index.php?title=Categoria:Alem%C3%A3o&diff=1870669&oldid=1840288
This causes the bug $ python pwb.py interwiki Utilizador:John_Vandenberg/test -family:wiktionary -lang:pt
I think we need to include closed wikis in Family.langs so they are normal Site objects, and use siteinfo['closed'] to where appropriate to dynamically determine 'obsolete', and we'll probably need to modify interwiki a bit. It is that last part which worries me, as we dont have the ability to set up interwiki test cases (or can test and test2.wikipedia be linked to each other?).
Change 170931 had a related patch set uploaded by John Vandenberg: [WIP] Allow lang links to obsolete sites https://gerrit.wikimedia.org/r/170931
The above patch has an intrinsic problem that it doesnt parse the langlink of an obsolete site. (see FIXME in page.py) I dont know what interwiki does with these langlinks, so I dont know whether the above breaks the algorithms in interwiki - I suspect it might, so testing is needed. If there are only minor breakages in interwiki, we might be able to work-around the breakages. If the breakages are large, we'll need to look for another solution.
Re 'interwiki', I am referring to interwiki.py, which is the main way the end-users interact with interwiki links to closed wikis.
