Last modified: 2014-09-17 20:10:13 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T72818, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 70818 - mediawiki.ui: dependency to module .anchor caused button regression
mediawiki.ui: dependency to module .anchor caused button regression
Status: REOPENED
Product: MediaWiki extensions
Classification: Unclassified
Echo (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 70424
  Show dependency tree / graph
 
Reported: 2014-09-13 23:26 UTC by Florian
Modified: 2014-09-17 20:10 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
regression in font of button (hover) (983 bytes, image/png)
2014-09-13 23:26 UTC, Florian 		Details
regression in font of button (focus) (1021 bytes, image/png)
2014-09-13 23:26 UTC, Florian 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Florian 2014-09-13 23:26:29 UTC 
Created attachment 16462 [details]
regression in font of button (hover)

I open this bug for Echo, because i haven't found any use for mediawiki.ui.anchor, so i want to ask the dev's if it's possible to remove this dependency from ext.echo.overlay:
https://github.com/wikimedia/mediawiki-extensions-Echo/blob/acce7cc9fbd093ab1d6149df7156ed77837cbe9c/Resources.php#L60

because it's unused (?) but caused a regression to buttons :hover and :focus color (see pictures) when wgUseMediaWikiUIEverywhere is true.
Comment 1 Florian 2014-09-13 23:26:46 UTC 
Created attachment 16463 [details]
regression in font of button (focus)
Comment 2 Matthew Flaschen 2014-09-16 03:39:40 UTC 
It's not unused, unfortunately (it's used for the "Alerts (0)" or however many you have, which is "(echo-notification-alert)"), but this is a valid bug.
Comment 3 Shahyar Ghobadpour 2014-09-17 18:14:31 UTC 
Should be resolved by https://gerrit.wikimedia.org/r/#/c/123804/
Comment 4 Florian 2014-09-17 18:40:15 UTC 
(In reply to Shahyar Ghobadpour from comment #3)
> Should be resolved by https://gerrit.wikimedia.org/r/#/c/123804/

Tested -> solved. Thanks!
Comment 5 Jon 2014-09-17 20:10:13 UTC 
Patch was reverted.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links