Last modified: 2014-10-02 06:58:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T72801, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 70801 - Buttons have text of same colour when focused
Buttons have text of same colour when focused
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
MediaWiki UI (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 70913
  Show dependency tree / graph
 
Reported: 2014-09-13 02:54 UTC by Jared Zimmerman (WMF)
Modified: 2014-10-02 06:58 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
guider button with incorrect rendering (87.75 KB, image/png)
2014-09-13 02:54 UTC, Jared Zimmerman (WMF) 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Jared Zimmerman (WMF) 2014-09-13 02:54:48 UTC 
Created attachment 16459 [details]
guider button with incorrect rendering

Both the buttons in the main popup and in the fixed header element are displaying incorrectly.
Comment 1 Matthew Flaschen 2014-09-13 06:04:23 UTC 
That's GettingStarted, not GuidedTour.  But it is indeed a regression in MediaWiki UI, due to the mediawiki.ui.anchor code.
Comment 2 Matthew Flaschen 2014-09-13 06:06:20 UTC 
Specificially, because the color is set unconditionally with .mw-ui-progressive:focus you get blue on blue.

I think this may be fixed by https://gerrit.wikimedia.org/r/#/c/155856/
Comment 3 Matthew Flaschen 2014-09-13 06:08:46 UTC 
What fixed header element are you referring to?  I assume the popup is the GettingStarted modal the screenshot shows.
Comment 4 Shahyar Ghobadpour 2014-09-17 18:13:32 UTC 
Resolved by https://gerrit.wikimedia.org/r/#/c/123804/

(Note: I don't appear to have permission to modify this bug.)
Comment 5 Matthew Flaschen 2014-09-18 06:59:33 UTC 
Reverted.

Shahyar, do you have permission to edit other bugs (I think it's a global setting)?  If not, you should request permission from Andre Klapper.
Comment 6 Gerrit Notification Bot 2014-09-29 21:05:29 UTC 
Change 155856 had a related patch set uploaded by Jdlrobson:
Change mw-ui anchors to require mw-ui-anchor base class, and introduce mw-ui-text base class

https://gerrit.wikimedia.org/r/155856
Comment 7 Jon 2014-09-29 21:07:03 UTC 
Please someone review Shahyar's patch. It's been sitting around for far too long.
Comment 8 Gerrit Notification Bot 2014-10-02 04:24:25 UTC 
Change 155856 merged by jenkins-bot:
Change mw-ui anchors to require mw-ui-anchor base class, and introduce mw-ui-text base class

https://gerrit.wikimedia.org/r/155856
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links