Last modified: 2014-09-09 18:21:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T72318, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 70318 - Echo should generate canonical diff links
Echo should generate canonical diff links
Status: UNCONFIRMED
Product: MediaWiki extensions
Classification: Unclassified
Echo (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 61489
  Show dependency tree / graph
 
Reported: 2014-09-03 01:05 UTC by Ryan Kaldari
Modified: 2014-09-09 18:21 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Ryan Kaldari 2014-09-03 01:05:08 UTC 
Right now Echo generates non-canonical diff links for various notifications. For example, when you receive an email about your talk page being editing, the link is in the form:
https://en.wikipedia.org/w/index.php?title=User_talk:Kaldari&oldid=prev&diff=623938341

Ideally, it should be in the form:
https://en.wikipedia.org/wiki/User_talk:Kaldari?oldid=prev&diff=623938341

Otherwise, things like mobile redirects don't work properly. See bug 61489 and bug 70312.
Comment 1 Kunal Mehta (Legoktm) 2014-09-03 18:21:20 UTC 
This sounds like a bug in mobile, not in Echo. If you add a query string to a url, MediaWiki core converts it to use the script path directly instead of short url.

> echo Title::newMainPage()->getFullUrl();
http://localhost/wiki/Main_Page
> echo Title::newMainPage()->getFullUrl("action=edit");
http://localhost/w/index.php?title=Main_Page&action=edit
Comment 2 Ryan Kaldari 2014-09-09 18:21:10 UTC 
Legoktm: The mobile bug (Bug 70312) was closed as WONTFIX per MaxSem. I'll discuss the issue with him further on that bug.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links