Last modified: 2014-09-03 01:13:34 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T63489, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 61489 - normal diff links don't redirect to MobileDiff
normal diff links don't redirect to MobileDiff
Status: REOPENED
Product: MobileFrontend
Classification: Unclassified
Feature requests (Other open bugs)
unspecified
All All
: Low normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on: 70318 70319
Blocks:
  Show dependency treegraph
 
Reported: 2014-02-18 14:07 UTC by Sage Ross
Modified: 2014-09-03 01:13 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Sage Ross 2014-02-18 14:07:19 UTC
When opening a diff link on mobile (such as one from a watchlist email), the desktop view is used.

For diffs between adjacent revisions at least (until MobileDiff can handle multipe-edit-diffs), diff links should redirect to the mobile view.

This would make my mobile workflow 10x better. I want to be able go from a watchlist email straight to the mobile diff view (and then thank people for good edits, yay!).
Comment 1 Bingle 2014-02-18 18:34:53 UTC
Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1710
Comment 2 Gerrit Notification Bot 2014-07-23 08:14:30 UTC
Change 148613 had a related patch set uploaded by Florianschmidtwelzow:
Redirect to mobile diff page

https://gerrit.wikimedia.org/r/148613
Comment 3 Ryan Kaldari 2014-07-31 19:05:16 UTC
Seems to be fixed now. If there are still any discrepancies, let me know.
Comment 4 Ryan Kaldari 2014-07-31 19:05:47 UTC
Opps, wrong bug :P
Comment 5 Gerrit Notification Bot 2014-08-19 00:21:54 UTC
Change 148613 merged by jenkins-bot:
Redirect to mobile diff page

https://gerrit.wikimedia.org/r/148613
Comment 6 Ryan Kaldari 2014-09-03 00:54:15 UTC
Apparently, there were two separate issues with this bug:
1. We weren't trying to redirect regular diffs to the MobileDiff view (this is fixed by https://gerrit.wikimedia.org/r/148613)
2. Non-canonical URLs do not get redirected to mobile by Varnish on purpose (so as not to cause problems with certain API calls, etc.) This is bug 70312.
Bug 70312 is a WONTFIX, so what we actually need to do now is reduce the number of interfaces that create non-canonical diff links in MediaWiki, especially when those links are likely to be used on a mobile device.

Sage: Do you remember where the link you were trying to follow came from? Echo maybe?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links