Last modified: 2014-09-19 23:27:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T71673, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 69673 - Stop using inline <img> for thumbnail magnify icon
Stop using inline <img> for thumbnail magnify icon
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
1.24rc
All All
: Normal normal (vote)
: ---
Assigned To: Bartosz Dziewoński
:
Depends on:
Blocks: 69277 69705
  Show dependency treegraph
 
Reported: 2014-08-17 18:45 UTC by Bartosz Dziewoński
Modified: 2014-09-19 23:27 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Bartosz Dziewoński 2014-08-17 18:45:18 UTC
Let's stop using inline <img> for thumbnail magnify icon. According to bug 69277 comment 11, there are 87619775 requests per day for 'magnify-clip.png'. It should be embedded in some piece of CSS.

(Bug 65160 / [[mw:Thumbnail style update]] call for complete removal of the icon, but it would only affect the Vector skin.)
Comment 1 Bartosz Dziewoński 2014-08-17 18:47:10 UTC
A number of extensions also refer to this file directly, including VisualEditor and WikiEditor. These will need to be updated.

There are probably also innumerable user scripts that refer to it. Looking at bug 69277 comment 10, the Popups gadget is a big offender.
Comment 2 James Forrester 2014-08-17 21:21:31 UTC
(In reply to Bartosz Dziewoński from comment #0)
> (Bug 65160 / [[mw:Thumbnail style update]] call for complete removal of the
> icon, but it would only affect the Vector skin.)

At this point this artefact would become a Monobook-only item, right? Should it be moved to that repo at that point?

(In reply to Bartosz Dziewoński from comment #1)
> A number of extensions also refer to this file directly, including
> VisualEditor and WikiEditor. These will need to be updated.

VisualEditor only uses it through mediawiki.content.styling.parsoid (faked Vector-like content rendering; yes yes, I know…), which should be fixed as the fixing for bug 65160.
Comment 3 Bartosz Dziewoński 2014-08-17 21:25:07 UTC
(In reply to James Forrester from comment #2)
> At this point this artefact would become a Monobook-only item, right? Should
> it be moved to that repo at that point?

No, it would become every-skin-but-Vector-including-custom-skins-only item.


> VisualEditor only uses it through mediawiki.content.styling.parsoid

It is also used in ve.ce.MWImageCaptionNode.js via 'magnifyClipIconURL' config item.
Comment 4 Ori Livneh 2014-08-17 22:35:57 UTC
(In reply to Bartosz Dziewoński from comment #0)
> Let's stop using inline <img> for thumbnail magnify icon. According to bug
> 69277 comment 11, there are 87619775 requests per day for
> 'magnify-clip.png'. It should be embedded in some piece of CSS.
> 
> (Bug 65160 / [[mw:Thumbnail style update]] call for complete removal of the
> icon, but it would only affect the Vector skin.)

Makes sense to me.
Comment 5 Gerrit Notification Bot 2014-08-18 15:25:31 UTC
Change 154830 had a related patch set uploaded by Bartosz Dziewoński:
Generate 'Enlarge' image in CSS rather than HTML (Linker)

https://gerrit.wikimedia.org/r/154830
Comment 6 Gerrit Notification Bot 2014-08-18 15:25:36 UTC
Change 154831 had a related patch set uploaded by Bartosz Dziewoński:
Remove WMF deployment hack for 'Enlarge' image

https://gerrit.wikimedia.org/r/154831
Comment 7 Gerrit Notification Bot 2014-08-19 23:51:23 UTC
Change 154830 merged by jenkins-bot:
Generate 'Enlarge' image in CSS rather than HTML (Linker)

https://gerrit.wikimedia.org/r/154830
Comment 8 James Forrester 2014-08-19 23:54:53 UTC
Deeming this merged now, as this is 'fixed' even without the clean-up from Gerrit change #154831 landing.
Comment 9 Gerrit Notification Bot 2014-09-19 23:12:21 UTC
Change 161625 had a related patch set uploaded by Jforrester:
Remove WMF deployment hack for 'Enlarge' image

https://gerrit.wikimedia.org/r/161625
Comment 10 Gerrit Notification Bot 2014-09-19 23:19:16 UTC
Change 154831 merged by jenkins-bot:
Remove WMF deployment hack for 'Enlarge' image

https://gerrit.wikimedia.org/r/154831
Comment 11 Gerrit Notification Bot 2014-09-19 23:27:09 UTC
Change 161625 merged by jenkins-bot:
Remove WMF deployment hack for 'Enlarge' image

https://gerrit.wikimedia.org/r/161625

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links