Last modified: 2014-08-15 00:02:57 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
First Last Prev Next    This bug is not in your last search results.
Bug 69566 - Sporadic reports of users being served MW with no skins on 1.24wmf17
Sporadic reports of users being served MW with no skins on 1.24wmf17
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: code-update-regression
Depends on:
Blocks: wmf-deployment
  Show dependency tree / graph
 
Reported: 2014-08-14 20:23 UTC by Sam Reed (reedy)
Modified: 2014-08-15 00:02 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Screenshot by Mutante (111.78 KB, image/png)
2014-08-14 20:36 UTC, Bartosz Dziewoński 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Sam Reed (reedy) 2014-08-14 20:23:58 UTC 
Seems there's been at least a couple of reports of this so far...
Comment 1 Bartosz Dziewoński 2014-08-14 20:36:26 UTC 
Created attachment 16195 [details]
Screenshot by Mutante
Comment 2 Gerrit Notification Bot 2014-08-14 20:47:56 UTC 
Change 154138 had a related patch set uploaded by Legoktm:
Normalize key before creating a Skin object

https://gerrit.wikimedia.org/r/154138
Comment 3 Gerrit Notification Bot 2014-08-14 20:49:43 UTC 
Change 154139 had a related patch set uploaded by Legoktm:
Normalize key before creating a Skin object

https://gerrit.wikimedia.org/r/154139
Comment 4 Gerrit Notification Bot 2014-08-14 21:05:59 UTC 
Change 154138 merged by Bartosz Dziewoński:
Normalize key before creating a Skin object

https://gerrit.wikimedia.org/r/154138
Comment 5 Bartosz Dziewoński 2014-08-14 21:20:10 UTC 
The above patch, when deployed, should fix the issue for logged-in users who haven't changed their preferences in a very long time and had some values set that are currently invalid – these weren't being normalized properly and the users would get the fallback skin instead of the default skin, even thought the default skin was available.

Mutante said he saw that when logged-out, though, and we still have no idea what could possibly cause that (other than managing to hit the site at some split-second during deployment when not all files were there properly?). Bug 69284 may or may not be relevant.
Comment 6 Gerrit Notification Bot 2014-08-14 21:27:23 UTC 
Change 154139 merged by jenkins-bot:
Normalize key before creating a Skin object

https://gerrit.wikimedia.org/r/154139
Comment 7 Kunal Mehta (Legoktm) 2014-08-15 00:02:57 UTC 
Should be fixed now.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links