Last modified: 2014-08-21 15:48:18 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T71284, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 69284 - Make sure fallback skin is never cached
Make sure fallback skin is never cached
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
1.24rc
All All
: Unprioritized enhancement (vote)
: 1.24.0 release
Assigned To: Bartosz Dziewoński
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-08-08 08:48 UTC by Kunal Mehta (Legoktm)
Modified: 2014-08-21 15:48 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Kunal Mehta (Legoktm) 2014-08-08 08:48:47 UTC
Krinkle was saying that we should ensure that the fallback skin is never cached, maybe by sending a 500 status? (I don't remember exactly).
Comment 1 Bartosz Dziewoński 2014-08-08 22:13:49 UTC
OutputPage has some cache-controlling methods like enableClientCache( false ), would that be sufficient? We could call it from SkinFallback::initPage() or something.
Comment 2 Gerrit Notification Bot 2014-08-14 20:18:48 UTC
Change 154129 had a related patch set uploaded by Bartosz Dziewoński:
Never cache pages with the fallback skin

https://gerrit.wikimedia.org/r/154129
Comment 3 Gerrit Notification Bot 2014-08-21 15:44:47 UTC
Change 154129 merged by jenkins-bot:
Never cache pages with the fallback skin

https://gerrit.wikimedia.org/r/154129

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links