Last modified: 2014-10-29 23:53:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T71526, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 69526 - [HHVM] Tests on Travis are failing (due to HHVM's sqlsite driver)
[HHVM] Tests on Travis are failing (due to HHVM's sqlsite driver)
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
WikibaseQueryEngine (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Wikidata bugs
u=dev c=backend p=0
: hhvm
Depends on:
Blocks: 64415
  Show dependency treegraph
 
Reported: 2014-08-14 09:37 UTC by tobias.gritschacher
Modified: 2014-10-29 23:53 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description tobias.gritschacher 2014-08-14 09:37:48 UTC
This is due to a DBAL compatibility issue which still exists on master of DBAL.
Comment 1 Jeroen De Dauw 2014-08-14 15:10:00 UTC
Talked to the DBAL people. They say HHVMs sqlsite driver is not behaving cotrrectly. https://github.com/facebook/hhvm/issues/3467
Comment 2 tobias.gritschacher 2014-08-19 12:27:45 UTC
Per Jeroen: It's not DBAL apparently, but HHVM. While DBAL master's tests fail due to this, if we switch to DBAL master, our CI passes: https://travis-ci.org/wmde/WikibaseQueryEngine/jobs/32550010
Comment 3 Bill Schaller 2014-08-19 14:59:49 UTC
Even though your CI is passing, please note that it is not currently safe to use the HHVM PDO_SQLite adapter, as it doesn't handle errors properly.
Comment 4 Jeroen De Dauw 2014-08-19 20:45:31 UTC
I'm geussing this is also an issue for MediaWiki core? Or is core not using PDO for it's SQLSite support?
Comment 5 Max Semenik 2014-08-19 20:47:10 UTC
(In reply to Jeroen De Dauw from comment #4)
> I'm geussing this is also an issue for MediaWiki core? Or is core not using
> PDO for it's SQLSite support?

No, core uses PDO:Sqlite.
Comment 6 Jeroen De Dauw 2014-08-19 22:56:46 UTC
So core is not using PDO for it's SQLSite support but it uses PDO:Sqlite?

Huh? Do we have two things that are named way to similar here?
Comment 7 Max Semenik 2014-08-19 23:02:53 UTC
No, it's the same thing: PDO:Sqlite is the name of a particular driver:)
Comment 8 Jeroen De Dauw 2014-08-19 23:16:27 UTC
So then this is an issue for core if it where to use HHVM? Clearly it is not when it's using regular PHP.
Comment 9 Bill Schaller 2014-10-29 23:53:41 UTC
HHVM PDO bug is supposedly fixed -- https://github.com/facebook/hhvm/issues/3467

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links