Last modified: 2014-11-03 16:50:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T66415, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 64415 - Make Wikibase compatible with HHVM
Make Wikibase compatible with HHVM
Status: REOPENED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
master
All All
: Normal normal (vote)
: ---
Assigned To: Wikidata bugs
u=dev c=backend p=0
: hhvm, tracking
Depends on: 69524 69526 71295 64417 65698 69525 72040
Blocks: tracking 71519
  Show dependency treegraph
 
Reported: 2014-04-25 07:20 UTC by Adrian Lang
Modified: 2014-11-03 16:50 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Adrian Lang 2014-04-25 07:20:40 UTC

    
Comment 1 Ori Livneh 2014-09-26 06:34:22 UTC
The 1.25wmf1 branch is free of HHVM-specific errors, AFAICT.
Comment 2 Aude 2014-09-26 09:39:32 UTC
we still have issues on 1.25wmf1

I simply tried to view a diff (over many revisions):

https://test.wikidata.org/w/index.php?title=Q6&diff=8305&oldid=5032&uselang=en

In the logs, I see, the second which is mine and should be fixed with backport.  I can take care of the first one, also.

Sep 26 09:30:51 mw1017:  #012Fatal error: Argument 1 passed to Wikibase\RepoItemLinkGenerator::getEditLinksLink() must be an instance of Wikibase\EntityId, Wikibase\DataModel\Entity\ItemId given in /srv/mediawiki/php-1.25wmf1/extensions/Wikidata/extensions/Wikibase/client/includes/RepoItemLinkGenerator.php on line 140
Sep 26 09:35:52 mw1017:  #012Fatal error: Argument 1 passed to Wikibase\ClaimDifferenceVisualizer::formatPropertyId() must be an instance of Wikibase\EntityId, Wikibase\DataModel\Entity\PropertyId given in /srv/mediawiki/php-1.25wmf1/extensions/Wikidata/extensions/Wikibase/repo/includes/ClaimDifferenceVisualizer.php on line 276
Comment 3 Aude 2014-09-26 13:10:30 UTC
not yet fixed
Comment 4 Jan Zerebecki 2014-10-29 17:48:54 UTC
AFAIK all the actual problems we know of under HHVM were fixed. The dependent bugs are only about cleanups and automated tests.
Comment 5 Aude 2014-10-29 22:33:30 UTC
enabled hhvm again on wikidata as a beta feature and don't see any issues
Comment 6 Aude 2014-10-29 22:34:53 UTC
aaaha, this still depends on things that are still open.

i think this bug is fixed and doesn't depend on the other ones, imho, though

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links