Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T71344, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 69344 - Gadgets 2.0 doesn't pass jshint

Summary:	Gadgets 2.0 doesn't pass jshint

Status: RESOLVED FIXED Product: MediaWiki extensions Classification: Unclassified Component: Gadgets (Other open bugs) Version: unspecified Hardware: All All Importance: Unprioritized normal (vote) Target Milestone: --- Assigned To: Alex Monk URL: Whiteboard: Keywords: Depends on: Blocks: gadgets-2.0   Show dependency tree / graph		Reported: 2014-08-09 14:31 UTC by Kunal Mehta (Legoktm) Modified: 2014-09-01 21:33 UTC (History) CC List: 4 users (show) krenair krinklemail legoktm.wikipedia roan.kattouw See Also: Web browser: --- Mobile Platform: --- Assignee Huggle Beta Tester: ---

Attachments Add an attachment (proposed patch, testcase, etc.)

Description Kunal Mehta (Legoktm) 2014-08-09 14:31:07 UTC Comment 1 Kunal Mehta (Legoktm) 2014-08-09 15:16:04 UTC See <https://integration.wikimedia.org/ci/job/mwext-Gadgets-jslint/61/console> Comment 2 Alex Monk 2014-08-09 20:09:12 UTC Gerrit change #153220 Comment 3 Alex Monk 2014-08-09 21:11:39 UTC So we just need to fix this now: modules/ext.gadgets.gadgetmanager.js: line 369, col 25, '$el' is not defined. Comment 4 Kunal Mehta (Legoktm) 2014-09-01 21:33:18 UTC Change-Id: I17cb9576e92898ff735ba723cacd1331c8d0a413