Last modified: 2014-09-12 10:38:35 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T70261, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 68261 - Travis-CI / HHVM-nightly / Import.php fails on XMLReader::open
Travis-CI / HHVM-nightly / Import.php fails on XMLReader::open
Status: RESOLVED DUPLICATE of bug 66023
Product: MediaWiki
Classification: Unclassified
Export/Import (Other open bugs)
1.24rc
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: hhvm
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-07-19 03:16 UTC by MWJames
Modified: 2014-09-12 10:38 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description MWJames 2014-07-19 03:16:09 UTC
For sometime now SMW runs successfully all its unit tests [0] on Travis-CI/HHVM nightly except those that involve the `Import.php`.

When our regression tests try to import some XML via `Import.php`, the importer chokes on line 53 (`$this->reader->open( "uploadsource://$id" );`) with "Unable to open source data". (By normal standard the import runs without a problem for the same tests that do not involve HHVM).

Travis-CI test environment:

PHPUnit 4.1.4
PHP 5.6.99-hhvm / HipHop VM 3.2.0-dev+2014.07.17 (rel)
MW master (1.24+)
DB-type sqlite

[0] https://travis-ci.org/SemanticMediaWiki/SemanticMediaWiki/jobs/30308020
Comment 1 Max Semenik 2014-07-19 04:17:12 UTC

*** This bug has been marked as a duplicate of bug 66023 ***
Comment 2 dan 2014-09-12 10:25:00 UTC
the issue seems to be related to the custom stream that is created in Import.php using $id = UploadSourceAdapter::registerSource( $source ); and then $this->reader->open( "uploadsource://$id" );

GWToolset uses XMLReader->open() with uploaded XML files without a custom stream and has no problem.

so i'm not sure the issue lies in how hhvm implements XMLReader, but how it handles custom streams or how mw is creating the custom stream.
Comment 3 MWJames 2014-09-12 10:38:35 UTC
As noted in [0], HipHop VM 3.3.0-dev+2014.08.10 (rel) solved the issue for us.

[0] https://bugzilla.wikimedia.org/show_bug.cgi?id=66023#c5

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links